Code review comment for lp:~epics-core/epics-base/link-support-2

Revision history for this message
Andrew Johnson (anj) wrote :

Just committed a couple more changes, one of which will require you to modify your getValue() routine slightly (the pstat & psevr args have gone, look at the commit for why).

You should take a look at the new calc link type that I also added (some docs generated in links.html).

I agree about the cantProceed stuff, for now I was keeping the routines the same but we need to fix them properly including their call-sites. The new dbmfStrndup() will segfault like dbmfStrdup() if dbmfMalloc() ever returns NULL.

doCloseLinks() should close JSON_LINKs, I'll fix that later.

I'm hitting string length limits, dbpr can't display long JSON_LINK strings, and I think there's also a length limit to the long-string one can caput to a link field which will need to be increased somewhat.

I need to stop for supper now, later!

« Back to merge proposal