Code review comment for lp:~epics-core/epics-base/link-support-2

Revision history for this message
Andrew Johnson (anj) wrote :

> the jlif free callback isn't being called if parsing is stopped

I partially fixed that in last night's commit, but there are more places in dbJLink.c that need fixes. I'll work on that tonight.

> I see that alloc_link no longer gets a DBLINK* argument.

Your dbParseLink() routine doesn't get the link pointer, so I couldn't pass it on (I was using it for that too). Obviously I could add it, but actually I think the inability to access the link at parse-time is probably good protection from someone writing a link type that changes the fields in the link while parsing the string instead of storing the parse results in their jlink. I believe the record and link field name will get printed anyway as long as the parse is aborted (that's probably new with last night's commit though). dbParseLink() doesn't print any error messages at the moment either.

This latest version is almost sufficient for child links (just one more jlif routine to add) and with that there's the question of how to identify a link embedded inside another link inside a record instance. Children get a link to their parent so can print the names of their antecedents, but they don't currently know how to self-identify among siblings.

« Back to merge proposal