Code review comment for lp:~epics-core/epics-base/ioc-shutdown2

Revision history for this message
Andrew Johnson (anj) wrote :

On 07/11/2014 09:49 AM, mdavidsaver wrote:
>>> The testdbPrepare() routine could call eltc(0) ...
>> Ok. ...
>
> I'm reconsidering this. Do we really want to hide all messages?

Maybe not; several of our tests do trigger errlog warning messages from
the facilities they are testing, but I guess when that's expected the
test program should be using eltc to suppress them – there are three
programs in libCom/test and one in ioc/db/test that currently do that.

> Also, if this were done, shouldn't this be done in testPlan()?

That would couple the epicsUnitTest code directly to errlog which would
be a bad thing. Currently only some of the test programs will pull in
errlog, whereas the IOC definitely requires it to be present in the
executable.

You're right, that was probably not a good idea.

- Andrew
--
Advertising may be described as the science of arresting the human
intelligence long enough to get money from it. -- Stephen Leacock

« Back to merge proposal