Code review comment for lp:~epics-core/epics-base/ioc-shutdown2

Revision history for this message
Andrew Johnson (anj) wrote :

On 07/10/2014 05:40 PM, mdavidsaver wrote:
> Function names changed as requested.

You misunderstood a couple of my suggestions; I meant dbShutdownTest to
look like this:

    testdbReadDatabase("xRecord.db", NULL, NULL);

    testIocInitOk();

    epicsThreadMap(findCommonThread);
    checkCommonThreads();

    testIocShutdownOk();

    testdbCleanup();

The ...Ok() functions should incorporate calls to testOk() so the user
doesn't have to remember whether she needs to invert the result or not,
and should also use explicit text such as "IOC Initialized".

- Andrew
--
Advertising may be described as the science of arresting the human
intelligence long enough to get money from it. -- Stephen Leacock

« Back to merge proposal