Code review comment for lp:~epics-core/epics-base/epicsTime-status

Revision history for this message
mdavidsaver (mdavidsaver) wrote :

> The problem with keeping the epicsTimeERROR definition is that any code that equality compares it with a returned status value will stop working.

Good point.

FYI the case I have is:

https://github.com/epics-modules/mrfioc2/blob/master/evrApp/src/evrGTIF.cpp

The important thing is to have code which works for both <=3.15 and >=3.16, which could be done the in way you mention.

review: Approve

« Back to merge proposal