Code review comment for lp:~epics-core/epics-base/bigdb

Revision history for this message
mdavidsaver (mdavidsaver) wrote :

> Please adjust or remove the comment at dbStaticLib.c:1415.
> The new ellSort.c file should have a copyright/license header.

Done

> I don't recognize any of the chiark website's example C code
> in it, so I'm guessing you wrote this yourself from scratch

Correct. I just want to give due credit. I went looking for the best way to sort linked lists, and there was a well thought out answer waiting.

> Have you tried removing the sort completely?

Yup. Works fine. I couldn't find anything in Base which depends on the ordering.

> ... dates back to when dbStaticLib.c was first added to CVS in 1993 ...

I know. There was dust, and spiders.

« Back to merge proposal