Code review comment for ~epics-core/epics-base/+git/database:putf-pact

Revision history for this message
Andrew Johnson (anj) wrote :

Should we also have a separate test case for an INP self link that is marked PP? Your latest commit isn't symmetrical between src and dst, and I'm not certain whether this handles the INP case as well — an extra test would dispel that concern.

Regarding the names, just putting the verb before the noun helps a little with comprehension, so setsrc would be one step better. Looking deeper, these variables are controlling whether the code lower down should mark the src/dst record and then unmark it again after record processing, so instead of "set" the verb could be "mark". If I've read it right though that mark is actually saying "my thread currently owns this record" so maybe the verb should be "claim" so claimsrc/claimSrc/claim_src.

« Back to merge proposal