Code review comment for ~epics-core/epics-base/+git/database:putf-pact
Revision history for this message
| Andrew Johnson (anj) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
What does the "set" part of your new variable names stand for? They don't read very obviously to me, especially out of the context of this bug-fix. The srcset/dstset variable is true if the psrc/pdst record has no procThread ID set, but I don't get any feel for what this means (weset in the previous iteration had a similar problem). Can you find something more meaningful?
You're still putting assert() statements in code that runs frequently inside the IOC. You may be more certain than last time that these assertions should never fire, but that makes IOCs more likely to die in the event of a memory error. I would prefer that these conditions just generate a warning (and maybe set procThread to whatever it's supposed to be if that's possible) without stopping the IOC thread. Brittle IOC code doesn't contribute to 98+% beam availability.
This doesn't look like it should have any problems with the synapps busy record, but have you tried it?