Code review comment for ~epics-core/epics-base/+git/Com:make-simple

Revision history for this message
Andrew Johnson (anj) wrote :

The Makefile rule for %ModuleDirs.pm cannot be removed, it will still be needed for external Perl scripts that use Perl modules from Base. The caPerl makeBaseApp template demonstrates the need.

You didn't make the changes I suggested in the last paragraph of my first comment yet: Remove the now unnecessary 'no lib $Bin;' lines from the scripts modules/database/src/tools/*.pl and modules/libcom/src/env/bldEnvData.pl where you removed a 'use ...ModuleDirs;' line.

I still object that the libcom, ca and database directories appear under modules/ when after these changes they aren't structured as modules any more. If we're going to undo their modular nature like this they should be moved back under src/ and test/.

One point of our making them modules was to move towards allowing CA and RSRV to become optional and unbundling them — are you abandoning that idea?

« Back to merge proposal