Code review comment for lp:~ensoft-opensource/ensoft-sextant/minor_bugfixes

Revision history for this message
ChrisD (gingerchris) wrote :

Ok, I'd remove that "level" line - I doubt we want debug level on by
default.

I'd suggest we do as the @@@ suggests and add something like

        parser.add_argument('-v', '--verbose',
                            action='store_true', help="Show debug")
...
        if args.verbose:
            logging.setLevel(logging.DEBUG)

On 26 August 2014 15:06, Patrick Stevens <email address hidden> wrote:

> I think it's because of Phil's addition:
>
> logging.config.dictConfig({
> "version": 1,
> "handlers": {
> "console": {
> "class": "logging.StreamHandler",
> "level": logging.INFO,
> "stream": "ext://sys.stderr",
> },
> },
> "root": {
> "level": logging.DEBUG,
> "handlers": ["console"],
> },
> })
>
> which appears in sextant.environment or sextant.__main__, depending on
> which revision you're looking at.
>
> Patrick
>
> On 26/08/14 15:02, Chris wrote:
> > Did we work out why info logging was coming out?
> > As discussed I thought logging defaulted to the level above info.
>
>
> --
>
> https://code.launchpad.net/~ensoft-opensource/ensoft-sextant/minor_bugfixes/+merge/232219
> Your team Ensoft Open Source is subscribed to branch
> lp:~ensoft-opensource/ensoft-sextant/auditing.
>

« Back to merge proposal