Merge ~enr0n/ubuntu-release-upgrader:lp.1947581 into ubuntu-release-upgrader:ubuntu/main

Proposed by Nick Rosbrook
Status: Merged
Merged at revision: db4b35f9c4024c4dd36134b2f239de75f8dce1ba
Proposed branch: ~enr0n/ubuntu-release-upgrader:lp.1947581
Merge into: ubuntu-release-upgrader:ubuntu/main
Diff against target: 35 lines (+8/-4)
2 files modified
DistUpgrade/DistUpgradeView.py (+4/-4)
debian/changelog (+4/-0)
Reviewer Review Type Date Requested Status
Brian Murray Approve
Review via email: mp+415051@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

This looks great, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/DistUpgrade/DistUpgradeView.py b/DistUpgrade/DistUpgradeView.py
index 3d9510f..8b8b904 100644
--- a/DistUpgrade/DistUpgradeView.py
+++ b/DistUpgrade/DistUpgradeView.py
@@ -167,10 +167,10 @@ class AcquireProgress(apt.progress.base.AcquireProgress):
167 def estimatedDownloadTime(self, required_download):167 def estimatedDownloadTime(self, required_download):
168 """ get the estimated download time """168 """ get the estimated download time """
169 if self.est_speed == 0:169 if self.est_speed == 0:
170 timeModem = required_download/(56*1024/8) # 56 kbit 170 time5Mbit = required_download/(5*1000*1000/8) # 1Mbit = 1000 kbit
171 timeDSL = required_download/(1024*1024/8) # 1Mbit = 1024 kbit171 time40Mbit = required_download/(40*1000*1000/8)
172 s= _("This download will take about %s with a 1Mbit DSL connection "172 s= _("This download will take about %s with a 40Mbit connection "
173 "and about %s with a 56k modem.") % (FuzzyTimeToStr(timeDSL), FuzzyTimeToStr(timeModem))173 "and about %s with a 5Mbit connection.") % (FuzzyTimeToStr(time40Mbit), FuzzyTimeToStr(time5Mbit))
174 return s174 return s
175 # if we have a estimated speed, use it175 # if we have a estimated speed, use it
176 s = _("This download will take about %s with your connection. ") % FuzzyTimeToStr(required_download/self.est_speed)176 s = _("This download will take about %s with your connection. ") % FuzzyTimeToStr(required_download/self.est_speed)
diff --git a/debian/changelog b/debian/changelog
index 122bd90..5a85141 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,7 +1,11 @@
1ubuntu-release-upgrader (1:22.04.5) UNRELEASED; urgency=medium1ubuntu-release-upgrader (1:22.04.5) UNRELEASED; urgency=medium
22
3 [ Brian Murray ]
3 * debian/control: rename the main branch4 * debian/control: rename the main branch
45
6 [ Nick Rosbrook ]
7 * DistUpgrade: update download rates in estimated download message (LP: #1947581)
8
5 -- Brian Murray <brian@ubuntu.com> Fri, 28 Jan 2022 13:43:11 -08009 -- Brian Murray <brian@ubuntu.com> Fri, 28 Jan 2022 13:43:11 -0800
610
7ubuntu-release-upgrader (1:22.04.4) jammy; urgency=medium11ubuntu-release-upgrader (1:22.04.4) jammy; urgency=medium

Subscribers

People subscribed via source and target branches