Code review comment for lp:~emmeran/kicad/kicad-optionalblockdialog

On 02/19/2013 05:57 PM, Emmeran wrote:
> I wasn't trying to say that it's bad, nor that it should be changed or anything. Feel free to use any layout you want.
>
> I was just stating my personal preference, which of course isn't at all important.
>
> Sorry if this offended you, wasn't meant like that at all.

It was difficult watching you hurt your cause.

We want to grow the team of "testing-committers" with people who are
competent and respectful, respectful of other developers and
respectful of the coding standards document.

Algorithms and data structures are reasonable targets of critique.
The "coding standards", on the other hand, are a stylistic choice
which at this point should live above the criticism of any one who is
trying to demonstrate their respect.

I was, and am still hopeful that you can eventually join team
testing-comitters. Each member of that team prefers committing code
over reviewing patches, and prefers being surrounded with other
respectful, competent developers.

The ways you can demonstrate respect for the coding standards are:

1) Make SURE your patches adhere to it.

2) Do not go on record as dis-liking it.

>
>> But of course it should be consistent within a project.
> With this I just validated that I need to apply your style to my code so that it's consistent within the project, which is the only that matters.
>
> As you perhaps already noticed, English is not my native language. So maybe my last comment came off smug or something. Sorry for that.

I did not notice. Your English is excellent.