review-tools

~emitorino/review-tools:default_public_snap

  1. Git
  2. lp:~emitorino/review-tools
  3. default_public_snap
Last commit made on 2022-07-28
Get this branch:
git clone -b default_public_snap https://git.launchpad.net/~emitorino/review-tools
Only Emilia Torino can upload to this branch. If you are Emilia Torino please log in for upload directions.

Branch merges

Branch information

Name:
default_public_snap
Repository:
lp:~emitorino/review-tools

Recent commits

27f1a95... by Emilia Torino

Add comment to snaps having a singe recipient

Signed-off-by: Maria Emilia Torino <email address hidden>

6447b42... by Emilia Torino

Add public snap

Signed-off-by: Maria Emilia Torino <email address hidden>

bafa5d5... by Alex Murray

Merge branch 'compare-snap-declaration-dict-values'

Signed-off-by: Alex Murray <email address hidden>

c92bcea... by Alex Murray

tests/test_sr_declaration.py: Remove unnecessary trailing commas

flake8 doesn't like these and they are not needed.

Signed-off-by: Alex Murray <email address hidden>

af25120... by Alex Murray

sr_declaration.py: Format code with black

Signed-off-by: Alex Murray <email address hidden>

f272081... by Alex Murray

sr_declaration.py: Fix handling of non-dict decl constraints

As suggested by emitorino, the previous could would fail if a declaration
was malformed and contained a list of items for a plug attribute so add a
specific test case for this and fix the existing code.

Signed-off-by: Alex Murray <email address hidden>

19965ea... by Alex Murray

tests/test_sr_declaration.py: Annotate subtest with test case name

This makes it a lot easier to identify which sub test case is failing.

Signed-off-by: Alex Murray <email address hidden>

ab08b83... by Alex Murray

tests/test_sr_declaration.py: Add additional test-cases for attr types

Signed-off-by: Alex Murray <email address hidden>

6e984c9... by Alex Murray

tests/test_sr_declaration.py: Add additional test-cases for attr types

Signed-off-by: Alex Murray <email address hidden>

5bc8447... by Alex Murray

sr_declaration.py: Fix compare of dict attrs between snap and decl

The snap declaration can contain additional attributes which are not
present in a given snap's yaml so make sure we compare one as a subset of
the other. Also add a test case for this check as suggested by emitorino in
https://code.launchpad.net/~alexmurray/review-tools/+git/review-tools/+merge/423650/comments/1128752

Signed-off-by: Alex Murray <email address hidden>