review-tools

Merge ~emitorino/review-tools:update_for_public_snaps into review-tools:master

  1. Git
  2. lp:~emitorino/review-tools
  3. update_for_public_snaps
  4. Merge into master
Proposed by Emilia Torino
Status: Merged
Merged at revision: 8041cea2e99398d9570914472fcfa9edcbcc8b0b
Proposed branch: ~emitorino/review-tools:update_for_public_snaps
Merge into: review-tools:master
Diff against target: 85 lines (+28/-2)
1 file modified
reviewtools/overrides.py (+28/-2)
Reviewer Review Type Date Requested Status
Alex Murray Approve
Review via email: mp+436718@code.launchpad.net

Commit message

- overrides.py: add/update for public snaps

To post a comment you must log in.
Revision history for this message
Alex Murray (alexmurray) wrote :

LGTM! Thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/reviewtools/overrides.py b/reviewtools/overrides.py
2index 0ae417c..2ff8dc0 100644
3--- a/reviewtools/overrides.py
4+++ b/reviewtools/overrides.py
5@@ -997,6 +997,22 @@ canonical_anbox = ["stephane.graber@canonical.com", "simon.fels@canonical.com"]
6
7 canonical_bootstack = ["bootstack-engineering@lists.canonical.com"]
8
9+canonical_bootstack_devops = [
10+ "ramesh.sattaru@canonical.com",
11+ "andrea.ieri@canonical.com",
12+ "eric.chen@canonical.com",
13+ "martin.kalcok@canonical.com",
14+ "robert.gildein@canonical.com",
15+ "james.lin@canonical.com",
16+ "mert.kirpici@canonical.com",
17+ "sudeep.bhandari@canonical.com",
18+ "chiwai.chan@canonical.com",
19+ "ashley.james@canonical.com",
20+ "tianqi.xiao@canonical.com",
21+ "gabriel.cocenza@canonical.com",
22+ "erhan.sunar@canonical.com",
23+]
24+
25 canonical_charmcraft = [
26 "facundo.batista@canonical.com",
27 "sergio.schvezov@canonical.com",
28@@ -1056,10 +1072,15 @@ canonical_livepatch = ["benjamin.romer@canonical.com", "marcelo.cerri@canonical.
29
30 canonical_lp = ["william.grant@canonical.com", "colin.watson@canonical.com"]
31
32-canonical_lxd = ["stephane.graber@canonical.com", "free.ekanayaka@canonical.com"]
33+canonical_lxd = ["stephane.graber@canonical.com", "simon.deziel@canonical.com"]
34
35 canonical_maas = ["adam.collard@canonical.com", "maas-crew@lists.canonical.com"]
36
37+canonical_microceph = [
38+ "stephane.graber@canonical.com",
39+ "chris.macnaughton@canonical.com",
40+]
41+
42 canonical_mir = [
43 "alan.griffiths@canonical.com",
44 "gerry.boland@canonical.com",
45@@ -1136,6 +1157,7 @@ update_publisher_overrides = {
46 "chromium-ffmpeg": ["olivier.tilloy@canonical.com"] + canonical_desktop,
47 "chromium-mir-kiosk": ["olivier.tilloy@canonical.com"] + canonical_mir,
48 "classic": canonical_snapd,
49+ "cloudstats": canonical_bootstack_devops,
50 "cm3": canonical_snapd,
51 "conjure-up": canonical_k8s,
52 "core": canonical_snapd,
53@@ -1235,13 +1257,15 @@ update_publisher_overrides = {
54 "mediatek-genio": canonical_enablement,
55 "mediatek-genio-kernel": canonical_kernel,
56 "mesa-core20": canonical_mir,
57- "microceph": canonical_openstack + canonical_lxd,
58+ "microceph": canonical_openstack + canonical_microceph,
59+ "microcloud": canonical_lxd,
60 "microk8s": canonical_k8s,
61 "microk8s-integrator-macos": canonical_k8s,
62 "microk8s-integrator-windows": canonical_k8s,
63 "microstack": canonical_openstack,
64 "mir-kiosk": canonical_mir,
65 "mir-kiosk-apps": canonical_mir,
66+ "mir-libs": canonical_mir,
67 "modem-manager": canonical_enablement,
68 "multipass": canonical_multipass,
69 "multipass-sshfs": canonical_multipass,
70@@ -1269,6 +1293,7 @@ update_publisher_overrides = {
71 # TODO: update to have more than one recipient when available
72 "prometheus-blackbox-exporter": ["james.simpson@canonical.com"],
73 "prometheus-bind-exporter": ["james.simpson@canonical.com"],
74+ "prometheus-grok-exporter": canonical_bootstack,
75 "prometheus-libvirt-exporter": canonical_bootstack,
76 "prometheus-ovn-exporter": canonical_openstack,
77 "prometheus-ovs-exporter": canonical_openstack,
78@@ -1327,6 +1352,7 @@ update_publisher_overrides = {
79 "ubuntu-desktop-session": canonical_desktop,
80 "ubuntu-frame": canonical_mir,
81 "ubuntu-frame-osk": canonical_mir,
82+ "ubuntu-frame-vnc": canonical_mir,
83 "ubuntu-image": canonical_foundations,
84 "udisks2": canonical_enablement,
85 "uefi-fw-tools": canonical_enablement,

Subscribers

People subscribed via source and target branches