Code review comment for ~emitorino/review-tools:multi_value_attrs_in_decl

Revision history for this message
Emilia Torino (emitorino) wrote :

> lgtm, wondering if the code can be simplified now though, as the code for
> lists _chec_attrib and the top loop do similar things ?

Thanks for this comment. I indeed simplified the rules processing code but had to extend a bit more the _chec_attrib to support considering lists in "against" (rules) for non-lists in val (snap decl).

« Back to merge proposal