Merge ~emitorino/review-tools:fix/black_format_updates into review-tools:master

[Emilia Torino]

Fixing black format issues

-reviewtools/sr_common.py: reformatting code using black
-reviewtools/tests/test_sr_declaration.py: reformatting code using black

[Jamie Strandboge (jdstrand)]

Huh, what version of black are you using? I'm getting different results here...

review: Needs Information

[Jamie Strandboge (jdstrand)]

We discussed this on mattermost. The difference is coming from Emi using pip installed black and me using distro installed black (focal). We decided to use black from beta instead. Note, black is run as part of snap builds (which will use black from the archive), but its use is informational in those builds.

Feel free to update as needed for black in beta and commit.

review: Approve

[Alex Murray (alexmurray)]

Jamie, to clarify - when you say 'black from beta' do you mean the beta channel of https://snapcraft.io/black ?

diff --git a/reviewtools/sr_common.py b/reviewtools/sr_common.py
index 8968caf..a0a4cf9 100644
--- a/reviewtools/sr_common.py
+++ b/reviewtools/sr_common.py
@@ -303,8 +303,8 @@ class SnapReview(Review):
     }
 
     interfaces_needing_reference_checks = [
-        'personal-files',
-        'system-files',
+        "personal-files",
+        "system-files",
     ]
 
     # most are from cmd/snap-confine/mount-support.c:sc_populate_mount_ns()
@@ -365,9 +365,10 @@ class SnapReview(Review):
             except Exception:  # pragma: nocover
                 error("Could not load snap/manifest.yaml. Is it properly " "formatted?")
 
-        self.base_declaration_series, self.base_declaration = (
-            read_snapd_base_declaration()
-        )
+        (
+            self.base_declaration_series,
+            self.base_declaration,
+        ) = read_snapd_base_declaration()
 
         # Add in-progress interfaces
         if self.base_declaration_series in self.inprogress_interfaces:
diff --git a/reviewtools/tests/test_sr_declaration.py b/reviewtools/tests/test_sr_declaration.py
index 859458c..12f936b 100644
--- a/reviewtools/tests/test_sr_declaration.py
+++ b/reviewtools/tests/test_sr_declaration.py
@@ -1306,7 +1306,7 @@ slots:
         self.check_results(r, expected=expected)
 
     def test__verify_declaration_invalid_slots_iface_constraint_slot_names_value_auto(
-        self
+        self,
     ):
         """Test _verify_declaration - invalid interface constraint slot-names
            (auto-connection)"""
@@ -1356,7 +1356,7 @@ slots:
         self.check_results(r, expected_counts)
 
     def test__verify_declaration_valid_plugs_iface_constraint_plug_names_value_auto(
-        self
+        self,
     ):
         """Test _verify_declaration - valid interface constraint plug-names
            (auto-connection)"""
@@ -1453,7 +1453,7 @@ slots:
         self.check_results(r, expected=expected)
 
     def test__verify_declaration_invalid_slots_plug_attribs_browser_support_nonexistent(
-        self
+        self,
     ):
         """Test _verify_declaration - invalid interface constraint attrib
            nonexistent"""
@@ -3273,7 +3273,7 @@ slots:
         self.check_results(r, expected=expected)
 
     def test_check_declaration_personal_files_alt_regex_match_unmatching_plug_names(
-        self
+        self,
     ):
         """Test check_declaration - personal-files - alternates regex match (unmatching plug-names)"""
         plugs = {
@@ -3585,7 +3585,7 @@ slots:
         self.check_results(r, expected=expected)
 
     def test_check_declaration_slots_deny_connection_attrib_list_match_matching_plug_names(
-        self
+        self,
     ):
         """Test check_declaration - slots/deny-connection/attrib - list match snap attribute str in decl list (matching plug-names)"""
         slots = {"iface-foo": {"interface": "foo", "attrib1": "b"}}
@@ -3618,7 +3618,7 @@ slots:
         self.check_results(r, expected=expected)
 
     def test_check_declaration_slots_deny_connection_attrib_list_match_unmatching_plug_names(
-        self
+        self,
     ):
         """Test check_declaration - slots/deny-connection/attrib - list match snap attribute str in decl list (unmatching plug-names)"""
         slots = {"iface-foo": {"interface": "foo", "attrib1": "b"}}