Merge lp:~elopio/unity/fix1181677-execute_action_by_id into lp:unity

Proposed by Leo Arias
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: no longer in the source branch.
Merged at revision: 3349
Proposed branch: lp:~elopio/unity/fix1181677-execute_action_by_id
Merge into: lp:unity
Diff against target: 19 lines (+3/-3)
1 file modified
tests/autopilot/unity/emulators/dash.py (+3/-3)
To merge this branch: bzr merge lp:~elopio/unity/fix1181677-execute_action_by_id
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Łukasz Zemczak Approve
Review via email: mp+164608@code.launchpad.net

Commit message

Fixed the execute_action_by_id on the dash emulator.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Makes sense indeed. As you mentioned, would be nice to have this tested somewhere, but I think that's a bit more work. +1

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/autopilot/unity/emulators/dash.py'
--- tests/autopilot/unity/emulators/dash.py 2013-05-15 15:58:52 +0000
+++ tests/autopilot/unity/emulators/dash.py 2013-05-19 07:27:29 +0000
@@ -408,12 +408,12 @@
408 return action408 return action
409 return None409 return None
410410
411 def execute_action_by_id(action_id, action):411 def execute_action_by_id(self, action_id):
412 """Executes an action given by the id."""412 """Executes an action given by the id."""
413 action = self.get_action_by_id(action_id)413 action = self.get_action_by_id(action_id)
414 if action:414 if action:
415 tx = action.x + (searchbar.width / 2)415 tx = action.x + (action.width / 2)
416 ty = action.y + (searchbar.height / 2)416 ty = action.y + (action.height / 2)
417 m = Mouse.create()417 m = Mouse.create()
418 m.move(tx, ty)418 m.move(tx, ty)
419 m.click()419 m.click()