Code review comment for lp:~elopio/unity-scope-click/update_new_scopes3

Revision history for this message
Leo Arias (elopio) wrote :

> 220 + 'updated=2014-05-15+14%3A29%3A38.679354&'
> 222 + 'created=2014-05-15+14%3A29%3A38.679344&'
>
> These are not necessary to have in this string. Let's drop them to avoid
> unnecessary content here.

Done

> 286 Depends: libautopilot-qt (>= 1.4),
> 299 ubuntu-ui-toolkit-autopilot,
> 300 unity8-autopilot,
>
> These aren't changed in your diff, but with the conversion to python3 here, I
> think these dependencies also need to be updated to depend on at least the
> versions of them which also use python3.

<elopio> dobey: dpkg-architecture -c sets the environment variable $DEB_HOST_MULTIARCH for the command passed as argument.
<elopio> ubuntu-ui-toolkit-autopilot and unity8-autopilot work with py2 and py3 for now. As soon as possible, the py2 support will be dropped.
<elopio> but they don't have a py3 specific version.
<dobey> elopio: the versions in trusty too?
<elopio> dobey: yes.
<elopio> I haven't ran all the tests in trusty yet, as I plan to enable them only on utopic for now.

« Back to merge proposal