Merge lp:~elopio/ubuntuone-testing/update-h into lp:ubuntuone-testing

Proposed by Leo Arias
Status: Merged
Approved by: Leo Arias
Approved revision: 88
Merged at revision: 78
Proposed branch: lp:~elopio/ubuntuone-testing/update-h
Merge into: lp:ubuntuone-testing
Prerequisite: lp:~elopio/ubuntuone-testing/stabilize-notes
Diff against target: 88 lines (+11/-11)
4 files modified
ubuntuone/web/tests/sst/shared/actions/dashboard.py (+1/-1)
ubuntuone/web/tests/sst/shared/actions/music.py (+1/-1)
ubuntuone/web/tests/sst/shared/actions/services.py (+4/-6)
ubuntuone/web/tests/sst/shared/utils/paymentperiods.py (+5/-3)
To merge this branch: bzr merge lp:~elopio/ubuntuone-testing/update-h
Reviewer Review Type Date Requested Status
Rick McBride (community) Approve
Review via email: mp+91193@code.launchpad.net

Commit message

Updated the locators that used headings.
Updated the plans messages.

Description of the change

Updated the locators that used headings.
Updated the plans messages.

To post a comment you must log in.
Revision history for this message
Rick McBride (rmcbride) wrote :

+1
also nicely done on the handling of december

review: Approve
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

The prerequisite lp:~elopio/ubuntuone-testing/stabilize-notes has not yet been merged into lp:ubuntuone-testing.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'ubuntuone/web/tests/sst/shared/actions/dashboard.py'
--- ubuntuone/web/tests/sst/shared/actions/dashboard.py 2011-12-13 23:05:13 +0000
+++ ubuntuone/web/tests/sst/shared/actions/dashboard.py 2012-02-02 01:29:19 +0000
@@ -37,4 +37,4 @@
37 assert_text(_get_welcome_element(), 'Hi %s! Welcome Back' % user_full_name)37 assert_text(_get_welcome_element(), 'Hi %s! Welcome Back' % user_full_name)
38 38
39def _get_welcome_element():39def _get_welcome_element():
40 return get_element_by_css('header > hgroup > h1')40 return get_element_by_css('h1')
4141
=== modified file 'ubuntuone/web/tests/sst/shared/actions/music.py'
--- ubuntuone/web/tests/sst/shared/actions/music.py 2012-01-25 17:52:50 +0000
+++ ubuntuone/web/tests/sst/shared/actions/music.py 2012-02-02 01:29:19 +0000
@@ -102,7 +102,7 @@
102 return song_row_element.get_attribute('data-u1m-songid')102 return song_row_element.get_attribute('data-u1m-songid')
103103
104def assert_player_title(number_of_song, total_songs):104def assert_player_title(number_of_song, total_songs):
105 player_title_element = get_element_by_css('.player > h1')105 player_title_element = get_element_by_css('.player > h2')
106 expected_title = 'Now playing %d of %d songs' \106 expected_title = 'Now playing %d of %d songs' \
107 % (number_of_song, total_songs)107 % (number_of_song, total_songs)
108 assert expected_title == player_title_element.text108 assert expected_title == player_title_element.text
109109
=== modified file 'ubuntuone/web/tests/sst/shared/actions/services.py'
--- ubuntuone/web/tests/sst/shared/actions/services.py 2011-12-09 18:19:11 +0000
+++ ubuntuone/web/tests/sst/shared/actions/services.py 2012-02-02 01:29:19 +0000
@@ -43,7 +43,7 @@
4343
44def assert_free_service_information():44def assert_free_service_information():
45 """Assert that the information about the free service is the expected."""45 """Assert that the information about the free service is the expected."""
46 get_element(tag='h1', text='Free')46 get_element(tag='h2', text='Free')
47 get_element(tag='li', text='File sync across platforms')47 get_element(tag='li', text='File sync across platforms')
48 get_element(tag='li', text='Share folders and files')48 get_element(tag='li', text='Share folders and files')
49 get_element(tag='li', text='Access on your mobile')49 get_element(tag='li', text='Access on your mobile')
@@ -53,9 +53,7 @@
53 the expected.53 the expected.
5454
55 """55 """
56 # TODO there are two Music Streaming elements. We should use xpath to be56 get_element(tag='h2', text='Music Streaming')
57 # sure that we are on the right section.
58 #get_element(tag='h1', text='Music Streaming')
59 get_element(css_class='try-free', text='Try for FREE')57 get_element(css_class='try-free', text='Try for FREE')
60 get_element(tag='li', text='Music streaming on your mobile')58 get_element(tag='li', text='Music streaming on your mobile')
61 get_element(tag='li', text='20 GB of Storage for all your data')59 get_element(tag='li', text='20 GB of Storage for all your data')
@@ -67,14 +65,14 @@
67 expected.65 expected.
6866
69 """67 """
70 get_element(tag='h1', text='Storage')68 get_element(tag='h2', text='Storage')
71 get_element(tag='li', text='20 GB')69 get_element(tag='li', text='20 GB')
72 get_element(tag='li', text='$2.99 / month')70 get_element(tag='li', text='$2.99 / month')
73 get_element(tag='li', text='or $29.99 / year')71 get_element(tag='li', text='or $29.99 / year')
7472
75def assert_discount_information():73def assert_discount_information():
76 """Assert that the yearly discount information is the expected."""74 """Assert that the yearly discount information is the expected."""
77 get_element(tag='h1', text='Discount')75 get_element(tag='h3', text='Discount')
78 get_element(tag='p', text='Two months free on Music Streaming and Storage '76 get_element(tag='p', text='Two months free on Music Streaming and Storage '
79 'when you sign up for 12 months')77 'when you sign up for 12 months')
8078
8179
=== modified file 'ubuntuone/web/tests/sst/shared/utils/paymentperiods.py'
--- ubuntuone/web/tests/sst/shared/utils/paymentperiods.py 2011-12-14 00:00:56 +0000
+++ ubuntuone/web/tests/sst/shared/utils/paymentperiods.py 2012-02-02 01:29:19 +0000
@@ -20,15 +20,17 @@
2020
21def get_monthly_expiration_date():21def get_monthly_expiration_date():
22 today = _get_today()22 today = _get_today()
23 next_month = None
23 if today.month != 12:24 if today.month != 12:
24 return today.replace(month=today.month + 1)25 next_month = today.replace(month=today.month + 1)
25 else:26 else:
26 return today.replace(month=1, year=today.year + 1)27 next_month = today.replace(month=1, year=today.year + 1)
28 return next_month + timedelta(days=1)
27 29
28def get_yearly_expiration_date():30def get_yearly_expiration_date():
29 today = _get_today()31 today = _get_today()
30 expiration_date = today.replace(year = today.year + 1)32 expiration_date = today.replace(year = today.year + 1)
31 return expiration_date + timedelta(days=1)33 return expiration_date
3234
33def get_trial_expiration_date():35def get_trial_expiration_date():
34 today = _get_today()36 today = _get_today()

Subscribers

People subscribed via source and target branches