Code review comment for lp:~elopio/ubuntu-ui-toolkit/textfield_emulators

Revision history for this message
Cris Dywan (kalikiana) wrote :

I don't quite like that clear() is very dynamic - if a test is expected to have a text field with a clear button using that method will hide errors involving it not being there and this extends to write. I'd rather have - clear_with_button, clear_with_keys and write without clearing out of the box. Depending on the test convenience might be a factor but I'd hesitate before seeing what it looks like in practise.

test_textinput.py needs to be updated to use the new emulator.

review: Needs Fixing

« Back to merge proposal