Code review comment for lp:~elopio/ubuntu-ui-toolkit/listview-scroll_to_bottom

Revision history for this message
Leo Arias (elopio) wrote :

Thanks for reviewing Javier.
The changes on the delegate are pretty nice. I didn't know how to do that, but kalikiana gave me the code. You can do a loop by just using:
191 + model: 20
So elements from 0 to 19 are created.

About _is_element_clickable, you are right. I'm currently not taking care of horizontal scrolling. With vertical scrolling we solve most of the cases for current apps, but we'll need to add the other one soon. I'll make a comment and add a bug to implement it in a following branch.

For now, going back to work in progress as the drag in the phone is still to fast and is taking us further than we need. I have solved the slow drag in https://code.launchpad.net/~elopio/autopilot/fix1257055-slow_drag/+merge/202205 just waiting for thomi.

« Back to merge proposal