Code review comment for lp:~elopio/ubuntu-ui-toolkit/listview-scroll_to_bottom

Revision history for this message
Javier Collado (javier.collado) wrote :

The code looks good, but still I'm not familiar enough with it, so I have a
couple of questions:

- My understanding is that the statements in test_emulators.py in "delegate"
  (line 193 in the MP) create the elements that were previously created
  manually. Is that correct? How come that there isn't any loop counter or
  anything? Does using just one number as in "%1" mean that only the elements
  from 0 to 9 will be created?

- The _is_element_clickable method seems to make sense, but it doesn't consider
  the x coordinate. If the element is wide enough I guess it might happen that
  its center in the y axis is visible, but not the center in the x axis. Maybe
  there's some assumption or precondition that I'm missing?

« Back to merge proposal