Code review comment for lp:~elopio/ubuntu-ui-toolkit/fake_app_fixture

Revision history for this message
Leo Arias (elopio) wrote :

> My only comment, is that I don't like the "assert_desktop_file_contents"
> method. Instead of generating a long regular expression for the desktop file
> and check that there's a match for every key value pair in the expected
> contents dictionary, I'd parse the desktop file as a dictionary and run an
> assertion on both the dictionaries:

Right you are! It looks much better now.

« Back to merge proposal