Merge lp:~elopio/ubuntu-rssreader-app/update_autopilot_tests into lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk

Proposed by Leo Arias
Status: Merged
Approved by: Joey Chan
Approved revision: 135
Merged at revision: 134
Proposed branch: lp:~elopio/ubuntu-rssreader-app/update_autopilot_tests
Merge into: lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk
Diff against target: 47 lines (+7/-6)
3 files modified
listview/ListModePage.qml (+1/-0)
tests/autopilot/ubuntu_rssreader_app/emulators.py (+4/-4)
tests/autopilot/ubuntu_rssreader_app/tests/test_rssreader.py (+2/-2)
To merge this branch: bzr merge lp:~elopio/ubuntu-rssreader-app/update_autopilot_tests
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Shorts Developers Pending
Review via email: mp+193872@code.launchpad.net

Commit message

Updated the autopilot tests.

To post a comment you must log in.
Revision history for this message
Joey Chan (qqworini) wrote :

Will these changes trigger Jenkins Bot auto test ?

Revision history for this message
Leo Arias (elopio) wrote :

I'm not sure how is this configured for the rss reader. It's weird that the branch was allowed to diverge and have failing tests, so I suppose the bot is not running them.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'listview/ListModePage.qml'
--- listview/ListModePage.qml 2013-10-30 20:05:10 +0000
+++ listview/ListModePage.qml 2013-11-05 02:15:32 +0000
@@ -149,6 +149,7 @@
149149
150 Label {150 Label {
151 id: labelFeedname151 id: labelFeedname
152 objectName: "labelFeedname"
152153
153 text: model.feed_name154 text: model.feed_name
154 fontSize: "x-small"155 fontSize: "x-small"
155156
=== modified file 'tests/autopilot/ubuntu_rssreader_app/emulators.py'
--- tests/autopilot/ubuntu_rssreader_app/emulators.py 2013-10-10 16:52:39 +0000
+++ tests/autopilot/ubuntu_rssreader_app/emulators.py 2013-11-05 02:15:32 +0000
@@ -176,11 +176,11 @@
176176
177 def get_feed_in_feedlist(self, topic, feed):177 def get_feed_in_feedlist(self, topic, feed):
178 tab = self.get_topic_tab(topic)178 tab = self.get_topic_tab(topic)
179 itemList = tab.select_many("Subtitled", objectName="feedlistitems")179 itemList = tab.select_many("UbuntuShape", objectName="feedlistitems")
180 for item in itemList:180 for item in itemList:
181 splititem = item.subText.split(",")181 label = item.select_single("Label", objectName="labelFeedname")
182 if splititem[1] == " " + feed:182 if label.text == feed:
183 return item183 return item
184184
185 def get_editfeed_topic_valueselector(self):185 def get_editfeed_topic_valueselector(self):
186 return self.select_single_retry(186 return self.select_single_retry(
187187
=== modified file 'tests/autopilot/ubuntu_rssreader_app/tests/test_rssreader.py'
--- tests/autopilot/ubuntu_rssreader_app/tests/test_rssreader.py 2013-10-10 18:12:28 +0000
+++ tests/autopilot/ubuntu_rssreader_app/tests/test_rssreader.py 2013-11-05 02:15:32 +0000
@@ -360,9 +360,9 @@
360360
361 #click on news topic361 #click on news topic
362 topicValueselectorValue = self.main_view. \362 topicValueselectorValue = self.main_view. \
363 get_editfeed_valueselector_value("news")363 get_editfeed_valueselector_value("Ubuntu")
364 self.pointing_device.click_object(topicValueselectorValue)364 self.pointing_device.click_object(topicValueselectorValue)
365365
366 #verify topic has changed366 #verify topic has changed
367 self.assertThat(topicValueselectorValue.text,367 self.assertThat(topicValueselectorValue.text,
368 Eventually(Equals("news")))368 Eventually(Equals("Ubuntu")))

Subscribers

People subscribed via source and target branches