Merge lp:~elopio/ubuntu-rssreader-app/update_autopilot_tests into lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk

Proposed by Leo Arias
Status: Merged
Approved by: Joey Chan
Approved revision: 135
Merged at revision: 134
Proposed branch: lp:~elopio/ubuntu-rssreader-app/update_autopilot_tests
Merge into: lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk
Diff against target: 47 lines (+7/-6)
3 files modified
listview/ListModePage.qml (+1/-0)
tests/autopilot/ubuntu_rssreader_app/emulators.py (+4/-4)
tests/autopilot/ubuntu_rssreader_app/tests/test_rssreader.py (+2/-2)
To merge this branch: bzr merge lp:~elopio/ubuntu-rssreader-app/update_autopilot_tests
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Shorts Developers Pending
Review via email: mp+193872@code.launchpad.net

Commit message

Updated the autopilot tests.

To post a comment you must log in.
Revision history for this message
Joey Chan (qqworini) wrote :

Will these changes trigger Jenkins Bot auto test ?

Revision history for this message
Leo Arias (elopio) wrote :

I'm not sure how is this configured for the rss reader. It's weird that the branch was allowed to diverge and have failing tests, so I suppose the bot is not running them.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'listview/ListModePage.qml'
2--- listview/ListModePage.qml 2013-10-30 20:05:10 +0000
3+++ listview/ListModePage.qml 2013-11-05 02:15:32 +0000
4@@ -149,6 +149,7 @@
5
6 Label {
7 id: labelFeedname
8+ objectName: "labelFeedname"
9
10 text: model.feed_name
11 fontSize: "x-small"
12
13=== modified file 'tests/autopilot/ubuntu_rssreader_app/emulators.py'
14--- tests/autopilot/ubuntu_rssreader_app/emulators.py 2013-10-10 16:52:39 +0000
15+++ tests/autopilot/ubuntu_rssreader_app/emulators.py 2013-11-05 02:15:32 +0000
16@@ -176,11 +176,11 @@
17
18 def get_feed_in_feedlist(self, topic, feed):
19 tab = self.get_topic_tab(topic)
20- itemList = tab.select_many("Subtitled", objectName="feedlistitems")
21+ itemList = tab.select_many("UbuntuShape", objectName="feedlistitems")
22 for item in itemList:
23- splititem = item.subText.split(",")
24- if splititem[1] == " " + feed:
25- return item
26+ label = item.select_single("Label", objectName="labelFeedname")
27+ if label.text == feed:
28+ return item
29
30 def get_editfeed_topic_valueselector(self):
31 return self.select_single_retry(
32
33=== modified file 'tests/autopilot/ubuntu_rssreader_app/tests/test_rssreader.py'
34--- tests/autopilot/ubuntu_rssreader_app/tests/test_rssreader.py 2013-10-10 18:12:28 +0000
35+++ tests/autopilot/ubuntu_rssreader_app/tests/test_rssreader.py 2013-11-05 02:15:32 +0000
36@@ -360,9 +360,9 @@
37
38 #click on news topic
39 topicValueselectorValue = self.main_view. \
40- get_editfeed_valueselector_value("news")
41+ get_editfeed_valueselector_value("Ubuntu")
42 self.pointing_device.click_object(topicValueselectorValue)
43
44 #verify topic has changed
45 self.assertThat(topicValueselectorValue.text,
46- Eventually(Equals("news")))
47+ Eventually(Equals("Ubuntu")))

Subscribers

People subscribed via source and target branches