Code review comment for lp:~elopio/ubuntu-clock-app/refactor_timer_tests

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Wow! Well organised and look awesome. It just needs two small fixes.

521 + self.page.drag_page_up()
534 + self.page.drag_page_up()

In these two lines in test_timer.py you can the function drag_page_up() without checking if the interface is phone or tablet. As a result when I tested on my desktop using tablet interface, AP tried dragging the page up, however there was nothing to drag up. The test did still pass, but it would be nice to check the interface before doing this step.

A if loop like below should fix it.

if not self.main_view.wideAspect:
    + self.drag_page_up()

Otherwise this commit is ready for merge.

review: Needs Fixing

« Back to merge proposal