Code review comment for lp:~elopio/ubuntu-clock-app/refactor_timer_tests

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

547 - // TODO: Fix autopilot test first before enabling this change in another MP
548 - //PropertyChanges { target: namePreset; text: "Timer #" + (listPreset.listCount + 1) }
549 + PropertyChanges { target: namePreset; text: "Timer #" + (listPreset.listCount + 1) }

This fix is not present in the trunk. I believe this is an old remaining part from the add-timer-placeholder-text MP. Please revert this.

189 + self.drag_page_up()

I see this code in several places. It won't work for the following reasons,
a) You need a condition to check if dragging the page action is necessary in the first place since in the tablet interface there is dragging page up/down actions. This is why I added the if condition, if not(self.wideAspect) wherever I made the drag_page function calls. I don't see it in this MP.

« Back to merge proposal