Code review comment for lp:~elopio/u1-test-utils/payclient_data_objects

Revision history for this message
Leo Arias (elopio) wrote :

<pindonga> elopio, on the second mp: l. 8: this should be the result of landing the previous branch, not your own :)
<pindonga> elopio, l. 84: why redefine __init__ ? why not instead call super() and just add the extra pieces you need?
<pindonga> and I think that's sit
<elopio> pindonga: l. 8, yes, I left it in case you wanted to run the tests. I have it as work in progress to make sure I'll change it before landing.
<elopio> l. 84, I changed the country_code to a lazy property. So the super __init__ will fail if it tries to set it. I don't know a better solution. ideas?
<pindonga> elopio, you could just call super.__init__ passing country_code=self._get_country_code(country)
<pindonga> no need to have the lazy property at all
<elopio> pindonga: that makes more sense, right. I'll change it.

« Back to merge proposal