Code review comment for lp:~elopio/u1-test-utils/page-objects
Revision history for this message
| Matias Bordese (matiasb) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Liking the pages approach.
A few questions/comments:
- return_page should be a Page instance? related, a Page class is expected here (l.103)?
- the return_page argument seems to be just for checks? (verifying the user is correctly redirected after an action to that page); at first I thought it was a way to tell the action where to redirect me after it. I would expect getting a page instance as result and maybe the caller check the got object in an instance of the right page?
- shouldn't l.149 and l.332 be comments instead?