Code review comment for lp:~elopio/u1-test-utils/dash-tests

Revision history for this message
Leo Arias (elopio) wrote :

> 44 + # TODO We should check if the result is visible, instead of checking
> if
> 45 + # there are visible categories. I don't know how to do it, I'll ask
> 46 + # --elopio - 2013-05-19
>
> I thought the following was doing that:
>
> 91 - refresh_results_fn = lambda: len(category.get_results())
> 92 - test.assertThat(refresh_results_fn, Eventually(GreaterThan(0)))
> 93 - # Select first result as soon as it appears
> 94 - return category.get_results()[0]
>
> This also ensures that there is at least one result which the following
> doesn't seem to care about:
>
> 40 + return category.get_results()[0]

You are right. I copied that part of the code. Thanks.

> I'm not sure about why you thunk some methods to functions but as long as
> daughter classes can still redefine the methods, I don't have strong
> objections either.

My goal is to put this in a custom autopilot emulator that inherits from the one in unity. We still need a little work from the autopilot team for that.

« Back to merge proposal