Merge lp:~elopio/snappy/test1466779-hell-world.evil into lp:~snappy-dev/snappy/snappy-moved-to-github

[Leo Arias]

Added the functional test: TestCallBinaryWithPermissionDeniedMustPrintError

[John Lenton (chipaca)]

review: Approve

=== modified file '_integration-tests/tests/snappy_test.go'
--- _integration-tests/tests/snappy_test.go	2015-06-23 00:17:14 +0000
+++ _integration-tests/tests/snappy_test.go	2015-06-23 00:17:15 +0000
@@ -33,15 +33,16 @@
 
 type InstallSuite struct{}
 
-func (s *InstallSuite) installSnap(c *C, packageName string) []byte {
+func (s *InstallSuite) installSnap(c *C, packageName string) string {
 	return s.execCommand(c, "sudo", "snappy", "install", packageName)
 }
 
-func (s *InstallSuite) execCommand(c *C, cmds ...string) []byte {
+func (s *InstallSuite) execCommand(c *C, cmds ...string) string {
 	cmd := exec.Command(cmds[0], cmds[1:len(cmds)]...)
 	output, err := cmd.CombinedOutput()
-	c.Assert(err, IsNil, Commentf("Error: %v", output))
-	return output
+	stringOutput := string(output)
+	c.Assert(err, IsNil, Commentf("Error: %v", stringOutput))
+	return stringOutput
 }
 
 func (s *InstallSuite) SetUpSuite(c *C) {
@@ -61,7 +62,7 @@
 		".*\n" +
 		"hello-world   .* .*  canonical \n" +
 		".*\n"
-	c.Assert(string(installOutput), Matches, expected)
+	c.Assert(installOutput, Matches, expected)
 }
 
 func (s *InstallSuite) TestCallBinaryFromInstalledSnap(c *C) {
@@ -69,7 +70,25 @@
 
 	echoOutput := s.execCommand(c, "hello-world.echo")
 
-	c.Assert(string(echoOutput), Equals, "Hello World!\n")
+	c.Assert(echoOutput, Equals, "Hello World!\n")
+}
+
+func (s *InstallSuite) TestCallBinaryWithPermissionDeniedMustPrintError(c *C) {
+	s.installSnap(c, "hello-world")
+
+	cmd := exec.Command("hello-world.evil")
+	echoOutput, err := cmd.CombinedOutput()
+	c.Assert(err, NotNil, Commentf("hello-world.evil did not fail"))
+
+	expected := "" +
+		"Hello Evil World!\n" +
+		"This example demonstrates the app confinement\n" +
+		"You should see a permission denied error next\n" +
+		"/apps/hello-world.canonical/.*/bin/evil: \\d+: " +
+		"/apps/hello-world.canonical/.*/bin/evil: " +
+		"cannot create /var/tmp/myevil.txt: Permission denied\n"
+
+	c.Assert(string(echoOutput), Matches, expected)
 }
 
 func (s *InstallSuite) TestInfoMustPrintInstalledPackageInformation(c *C) {
@@ -78,5 +97,5 @@
 	infoOutput := s.execCommand(c, "sudo", "snappy", "info")
 
 	expected := "(?ms).*^apps: hello-world\n"
-	c.Assert(string(infoOutput), Matches, expected)
+	c.Assert(infoOutput, Matches, expected)
 }