Code review comment for lp:~elopio/snappy/goarm_tests

Revision history for this message
Federico Gimenez (fgimenez) wrote :

Looks very good :)

The tests are not passing for me, it seems that maybe we need [1] to be applied before this.

Also, with that in place I get an error about the set of CGO_ENABLED to 1 being executed two times, maybe 1 is the default value for it, we could set all the environment variables to known values before the assertions.

Thanks!

[1] https://code.launchpad.net/~fgimenez/snappy/setenv-closure-redefinition/+merge/269717

review: Needs Fixing

« Back to merge proposal