Code review comment for lp:~elopio/snappy/extract_integration_adt-run
Revision history for this message
| Leo Arias (elopio) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Federico, please check it again. I've pushed most things to autopkgtest.go, but didn't introduce any type.
I'm not quite convinced about rootPath and baseDir, basically because the name says the same but they are totally different. I'll think of a better name for each, and for a better name for both in a type. I'm about to leave, so if you are happy with this as a first step, please top-approve. And if you have the change you want in mind, please make an MP.
Thanks for the review!