Code review comment for lp:~elopio/snappy/extract_integration_adt-run

Revision history for this message
Federico Gimenez (fgimenez) wrote :

Very nice main.go! :D

Instead of having a single AdtRun method and passing to it the results of calling other public methods of the same package I would leave it as a private adtRun and expose an AdtRunRemote, which takes an ip and a port as its last arguments, and a AdtRunLocal with an imagePath parameter.

Maybe we could also design a type for gathering the common options of both methods, what do you think?

Thanks!

« Back to merge proposal