Code review comment for lp:~elopio/snappy/examples1

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

On Thu, Oct 8, 2015 at 3:56 AM, Leo Arias <email address hidden> wrote:

> The proposal to merge lp:~elopio/snappy/examples1 into lp:snappy has been
> updated.
>
> Description changed to:
>
> This branch is a request for comments. What I want to do is move as many
> tests that use examples to the examples_test.go. And use local snaps for
> the other tests. For example, in order to test that the info command works,
> we don't need to install anything from the store. This will better split
> the fast and slow tests, the errors due to the store or the examples will
> be in a single suite, and the data dir will contain just the things needed
> for most of the tests, no more and no less.
>

The only gotcha is sideloading attributes, signed by store snaps are not
sideloaded ones while unsinged ones are.

« Back to merge proposal