Merge lp:~elopio/snappy/backport-gocheck into lp:~snappy-dev/snappy/15.04-deprecated
- backport-gocheck
- Merge into 15.04-deprecated
Proposed by
Leo Arias
Status: | Merged |
---|---|
Approved by: | Leo Arias |
Approved revision: | 466 |
Merged at revision: | 465 |
Proposed branch: | lp:~elopio/snappy/backport-gocheck |
Merge into: | lp:~snappy-dev/snappy/15.04-deprecated |
Diff against target: |
671 lines (+69/-67) 44 files modified
clickdeb/deb_test.go (+2/-2) cmd/snappy/cmd_low_level_unpack_test.go (+1/-1) cmd/snappy/cmd_set_test.go (+2/-2) coreconfig/config_test.go (+2/-2) debian/control (+1/-1) dependencies.tsv (+1/-1) helpers/cmp_test.go (+1/-1) helpers/helpers_test.go (+1/-1) helpers/touch_test.go (+1/-1) logger/logger_test.go (+1/-1) oauth/oauth_test.go (+1/-1) partition/bootloader_grub_test.go (+1/-1) partition/bootloader_uboot_test.go (+1/-1) partition/partition_test.go (+2/-2) partition/utils_test.go (+1/-1) policy/policy_test.go (+3/-2) priv/priv_test.go (+1/-1) progress/progress_test.go (+2/-2) release/release_test.go (+2/-2) snappy/auth_test.go (+13/-13) snappy/build_test.go (+1/-1) snappy/click_test.go (+2/-2) snappy/common_test.go (+3/-2) snappy/config_test.go (+1/-1) snappy/datadir_test.go (+1/-1) snappy/dbus_test.go (+1/-1) snappy/firstboot_test.go (+1/-1) snappy/hashes_test.go (+1/-1) snappy/hwaccess_test.go (+1/-1) snappy/install_test.go (+1/-1) snappy/oem_test.go (+1/-1) snappy/parts_test.go (+1/-1) snappy/purge_test.go (+1/-1) snappy/remove_test.go (+1/-1) snappy/rollback_test.go (+1/-1) snappy/security_test.go (+1/-1) snappy/set_test.go (+1/-1) snappy/snapp_test.go (+1/-1) snappy/sort_test.go (+1/-1) snappy/systemimage_native_test.go (+1/-1) snappy/systemimage_test.go (+2/-2) snappy/timeout_test.go (+1/-1) snappy/udev_test.go (+1/-1) systemd/systemd_test.go (+2/-2) |
To merge this branch: | bzr merge lp:~elopio/snappy/backport-gocheck |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sergio Schvezov | Approve | ||
Federico Gimenez (community) | Approve | ||
Review via email:
|
Commit message
Backported the change to use gopkg.in/check.v1.
Description of the change
We need a more recent version of gocheck in order to backport the integration tests. They use some features that are not in launchpad, like TestName()
To post a comment you must log in.
Revision history for this message
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Sergio Schvezov (sergiusens) wrote : | # |
This should be a problem as it doesn't affect the (delivered part of the) product itself but the testing side and this should indeed just work.
I do see some carry over gofmt things, but meh :-)
review:
Approve
Revision history for this message
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Leo Arias (elopio) wrote : | # |
meh it is. Thanks to you both.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1 | === modified file 'clickdeb/deb_test.go' | |||
2 | --- clickdeb/deb_test.go 2015-06-03 19:12:24 +0000 | |||
3 | +++ clickdeb/deb_test.go 2015-08-02 12:24:18 +0000 | |||
4 | @@ -27,11 +27,11 @@ | |||
5 | 27 | "strings" | 27 | "strings" |
6 | 28 | "testing" | 28 | "testing" |
7 | 29 | 29 | ||
9 | 30 | . "launchpad.net/gocheck" | 30 | . "gopkg.in/check.v1" |
10 | 31 | "launchpad.net/snappy/helpers" | 31 | "launchpad.net/snappy/helpers" |
11 | 32 | ) | 32 | ) |
12 | 33 | 33 | ||
14 | 34 | // Hook up gocheck into the "go test" runner. | 34 | // Hook up check.v1 into the "go test" runner. |
15 | 35 | func Test(t *testing.T) { TestingT(t) } | 35 | func Test(t *testing.T) { TestingT(t) } |
16 | 36 | 36 | ||
17 | 37 | type ClickDebTestSuite struct { | 37 | type ClickDebTestSuite struct { |
18 | 38 | 38 | ||
19 | === modified file 'cmd/snappy/cmd_low_level_unpack_test.go' | |||
20 | --- cmd/snappy/cmd_low_level_unpack_test.go 2015-07-06 18:50:29 +0000 | |||
21 | +++ cmd/snappy/cmd_low_level_unpack_test.go 2015-08-02 12:24:18 +0000 | |||
22 | @@ -21,7 +21,7 @@ | |||
23 | 21 | "os" | 21 | "os" |
24 | 22 | "path/filepath" | 22 | "path/filepath" |
25 | 23 | 23 | ||
27 | 24 | . "launchpad.net/gocheck" | 24 | . "gopkg.in/check.v1" |
28 | 25 | ) | 25 | ) |
29 | 26 | 26 | ||
30 | 27 | func makeTempFile(c *C, content string) *os.File { | 27 | func makeTempFile(c *C, content string) *os.File { |
31 | 28 | 28 | ||
32 | === modified file 'cmd/snappy/cmd_set_test.go' | |||
33 | --- cmd/snappy/cmd_set_test.go 2015-03-26 09:12:58 +0000 | |||
34 | +++ cmd/snappy/cmd_set_test.go 2015-08-02 12:24:18 +0000 | |||
35 | @@ -20,10 +20,10 @@ | |||
36 | 20 | import ( | 20 | import ( |
37 | 21 | "testing" | 21 | "testing" |
38 | 22 | 22 | ||
40 | 23 | . "launchpad.net/gocheck" | 23 | . "gopkg.in/check.v1" |
41 | 24 | ) | 24 | ) |
42 | 25 | 25 | ||
44 | 26 | // Hook up gocheck into the "go test" runner | 26 | // Hook up check.v1 into the "go test" runner |
45 | 27 | func Test(t *testing.T) { TestingT(t) } | 27 | func Test(t *testing.T) { TestingT(t) } |
46 | 28 | 28 | ||
47 | 29 | type CmdTestSuite struct { | 29 | type CmdTestSuite struct { |
48 | 30 | 30 | ||
49 | === modified file 'coreconfig/config_test.go' | |||
50 | --- coreconfig/config_test.go 2015-04-14 16:46:57 +0000 | |||
51 | +++ coreconfig/config_test.go 2015-08-02 12:24:18 +0000 | |||
52 | @@ -24,10 +24,10 @@ | |||
53 | 24 | "path/filepath" | 24 | "path/filepath" |
54 | 25 | "testing" | 25 | "testing" |
55 | 26 | 26 | ||
57 | 27 | . "launchpad.net/gocheck" | 27 | . "gopkg.in/check.v1" |
58 | 28 | ) | 28 | ) |
59 | 29 | 29 | ||
61 | 30 | // Hook up gocheck into the "go test" runner. | 30 | // Hook up check.v1 into the "go test" runner. |
62 | 31 | func Test(t *testing.T) { TestingT(t) } | 31 | func Test(t *testing.T) { TestingT(t) } |
63 | 32 | 32 | ||
64 | 33 | var ( | 33 | var ( |
65 | 34 | 34 | ||
66 | === modified file 'debian/control' | |||
67 | --- debian/control 2015-07-22 06:06:41 +0000 | |||
68 | +++ debian/control 2015-08-02 12:24:18 +0000 | |||
69 | @@ -8,10 +8,10 @@ | |||
70 | 8 | dh-systemd, | 8 | dh-systemd, |
71 | 9 | fakeroot, | 9 | fakeroot, |
72 | 10 | golang-ar-dev, | 10 | golang-ar-dev, |
73 | 11 | golang-check.v1-dev, | ||
74 | 11 | golang-go, | 12 | golang-go, |
75 | 12 | golang-go-flags-dev, | 13 | golang-go-flags-dev, |
76 | 13 | golang-go.crypto-dev, | 14 | golang-go.crypto-dev, |
77 | 14 | golang-gocheck-dev, | ||
78 | 15 | golang-goconfigparser-dev, | 15 | golang-goconfigparser-dev, |
79 | 16 | golang-juju-loggo-dev, | 16 | golang-juju-loggo-dev, |
80 | 17 | golang-pb-dev, | 17 | golang-pb-dev, |
81 | 18 | 18 | ||
82 | === modified file 'dependencies.tsv' | |||
83 | --- dependencies.tsv 2015-07-22 12:17:49 +0000 | |||
84 | +++ dependencies.tsv 2015-08-02 12:24:18 +0000 | |||
85 | @@ -5,5 +5,5 @@ | |||
86 | 5 | github.com/juju/loggo git 4c7cbce140ca070eeb59a28f4bf9507e511711f9 2015-02-26T05:51:10Z | 5 | github.com/juju/loggo git 4c7cbce140ca070eeb59a28f4bf9507e511711f9 2015-02-26T05:51:10Z |
87 | 6 | github.com/mvo5/goconfigparser git 26426272dda20cc76aa1fa44286dc743d2972fe8 2015-02-12T09:37:50Z | 6 | github.com/mvo5/goconfigparser git 26426272dda20cc76aa1fa44286dc743d2972fe8 2015-02-12T09:37:50Z |
88 | 7 | github.com/mvo5/uboot-go git 361f6ebcbb54f389d15dc9faefa000e996ba3e37 2015-07-22T06:53:46Z | 7 | github.com/mvo5/uboot-go git 361f6ebcbb54f389d15dc9faefa000e996ba3e37 2015-07-22T06:53:46Z |
89 | 8 | gopkg.in/check.v1 git 64131543e7896d5bcc6bd5a76287eb75ea96c673 2014-10-24T13:38:53Z | ||
90 | 8 | gopkg.in/yaml.v2 git 49c95bdc21843256fb6c4e0d370a05f24a0bf213 2015-02-24T22:57:58Z | 9 | gopkg.in/yaml.v2 git 49c95bdc21843256fb6c4e0d370a05f24a0bf213 2015-02-24T22:57:58Z |
91 | 9 | launchpad.net/gocheck bzr gustavo@niemeyer.net-20140225173054-xu9zlkf9kxhvow02 87 | ||
92 | 10 | 10 | ||
93 | === modified file 'helpers/cmp_test.go' | |||
94 | --- helpers/cmp_test.go 2015-04-17 06:42:44 +0000 | |||
95 | +++ helpers/cmp_test.go 2015-08-02 12:24:18 +0000 | |||
96 | @@ -23,7 +23,7 @@ | |||
97 | 23 | "path/filepath" | 23 | "path/filepath" |
98 | 24 | "strings" | 24 | "strings" |
99 | 25 | 25 | ||
101 | 26 | . "launchpad.net/gocheck" | 26 | . "gopkg.in/check.v1" |
102 | 27 | ) | 27 | ) |
103 | 28 | 28 | ||
104 | 29 | func (ts *HTestSuite) TestCmp(c *C) { | 29 | func (ts *HTestSuite) TestCmp(c *C) { |
105 | 30 | 30 | ||
106 | === modified file 'helpers/helpers_test.go' | |||
107 | --- helpers/helpers_test.go 2015-06-04 15:00:44 +0000 | |||
108 | +++ helpers/helpers_test.go 2015-08-02 12:24:18 +0000 | |||
109 | @@ -27,7 +27,7 @@ | |||
110 | 27 | "path/filepath" | 27 | "path/filepath" |
111 | 28 | "testing" | 28 | "testing" |
112 | 29 | 29 | ||
114 | 30 | . "launchpad.net/gocheck" | 30 | . "gopkg.in/check.v1" |
115 | 31 | ) | 31 | ) |
116 | 32 | 32 | ||
117 | 33 | func Test(t *testing.T) { TestingT(t) } | 33 | func Test(t *testing.T) { TestingT(t) } |
118 | 34 | 34 | ||
119 | === modified file 'helpers/touch_test.go' | |||
120 | --- helpers/touch_test.go 2015-04-13 17:00:53 +0000 | |||
121 | +++ helpers/touch_test.go 2015-08-02 12:24:18 +0000 | |||
122 | @@ -22,7 +22,7 @@ | |||
123 | 22 | "path/filepath" | 22 | "path/filepath" |
124 | 23 | "time" | 23 | "time" |
125 | 24 | 24 | ||
127 | 25 | . "launchpad.net/gocheck" | 25 | . "gopkg.in/check.v1" |
128 | 26 | ) | 26 | ) |
129 | 27 | 27 | ||
130 | 28 | func (ts *HTestSuite) TestUpdateTimestamp(c *C) { | 28 | func (ts *HTestSuite) TestUpdateTimestamp(c *C) { |
131 | 29 | 29 | ||
132 | === modified file 'logger/logger_test.go' | |||
133 | --- logger/logger_test.go 2015-03-31 14:12:52 +0000 | |||
134 | +++ logger/logger_test.go 2015-08-02 12:24:18 +0000 | |||
135 | @@ -28,7 +28,7 @@ | |||
136 | 28 | "time" | 28 | "time" |
137 | 29 | 29 | ||
138 | 30 | "github.com/juju/loggo" | 30 | "github.com/juju/loggo" |
140 | 31 | . "launchpad.net/gocheck" | 31 | . "gopkg.in/check.v1" |
141 | 32 | ) | 32 | ) |
142 | 33 | 33 | ||
143 | 34 | func Test(t *testing.T) { TestingT(t) } | 34 | func Test(t *testing.T) { TestingT(t) } |
144 | 35 | 35 | ||
145 | === modified file 'oauth/oauth_test.go' | |||
146 | --- oauth/oauth_test.go 2015-07-06 18:59:53 +0000 | |||
147 | +++ oauth/oauth_test.go 2015-08-02 12:24:18 +0000 | |||
148 | @@ -22,7 +22,7 @@ | |||
149 | 22 | import ( | 22 | import ( |
150 | 23 | "testing" | 23 | "testing" |
151 | 24 | 24 | ||
153 | 25 | . "launchpad.net/gocheck" | 25 | . "gopkg.in/check.v1" |
154 | 26 | ) | 26 | ) |
155 | 27 | 27 | ||
156 | 28 | func Test(t *testing.T) { TestingT(t) } | 28 | func Test(t *testing.T) { TestingT(t) } |
157 | 29 | 29 | ||
158 | === modified file 'partition/bootloader_grub_test.go' | |||
159 | --- partition/bootloader_grub_test.go 2015-04-30 11:28:39 +0000 | |||
160 | +++ partition/bootloader_grub_test.go 2015-08-02 12:24:18 +0000 | |||
161 | @@ -22,7 +22,7 @@ | |||
162 | 22 | "io/ioutil" | 22 | "io/ioutil" |
163 | 23 | "os" | 23 | "os" |
164 | 24 | 24 | ||
166 | 25 | . "launchpad.net/gocheck" | 25 | . "gopkg.in/check.v1" |
167 | 26 | ) | 26 | ) |
168 | 27 | 27 | ||
169 | 28 | func mockGrubFile(c *C, newPath string, mode os.FileMode) { | 28 | func mockGrubFile(c *C, newPath string, mode os.FileMode) { |
170 | 29 | 29 | ||
171 | === modified file 'partition/bootloader_uboot_test.go' | |||
172 | --- partition/bootloader_uboot_test.go 2015-07-23 11:58:40 +0000 | |||
173 | +++ partition/bootloader_uboot_test.go 2015-08-02 12:24:18 +0000 | |||
174 | @@ -24,7 +24,7 @@ | |||
175 | 24 | "strings" | 24 | "strings" |
176 | 25 | "time" | 25 | "time" |
177 | 26 | 26 | ||
179 | 27 | . "launchpad.net/gocheck" | 27 | . "gopkg.in/check.v1" |
180 | 28 | "launchpad.net/snappy/helpers" | 28 | "launchpad.net/snappy/helpers" |
181 | 29 | 29 | ||
182 | 30 | "github.com/mvo5/uboot-go/uenv" | 30 | "github.com/mvo5/uboot-go/uenv" |
183 | 31 | 31 | ||
184 | === modified file 'partition/partition_test.go' | |||
185 | --- partition/partition_test.go 2015-07-22 06:06:41 +0000 | |||
186 | +++ partition/partition_test.go 2015-08-02 12:24:18 +0000 | |||
187 | @@ -25,10 +25,10 @@ | |||
188 | 25 | "strings" | 25 | "strings" |
189 | 26 | "testing" | 26 | "testing" |
190 | 27 | 27 | ||
192 | 28 | . "launchpad.net/gocheck" | 28 | . "gopkg.in/check.v1" |
193 | 29 | ) | 29 | ) |
194 | 30 | 30 | ||
196 | 31 | // Hook up gocheck into the "go test" runner | 31 | // Hook up check.v1 into the "go test" runner |
197 | 32 | func Test(t *testing.T) { TestingT(t) } | 32 | func Test(t *testing.T) { TestingT(t) } |
198 | 33 | 33 | ||
199 | 34 | // partition specific testsuite | 34 | // partition specific testsuite |
200 | 35 | 35 | ||
201 | === modified file 'partition/utils_test.go' | |||
202 | --- partition/utils_test.go 2015-03-26 09:12:58 +0000 | |||
203 | +++ partition/utils_test.go 2015-08-02 12:24:18 +0000 | |||
204 | @@ -18,7 +18,7 @@ | |||
205 | 18 | package partition | 18 | package partition |
206 | 19 | 19 | ||
207 | 20 | import ( | 20 | import ( |
209 | 21 | . "launchpad.net/gocheck" | 21 | . "gopkg.in/check.v1" |
210 | 22 | ) | 22 | ) |
211 | 23 | 23 | ||
212 | 24 | type UtilsTestSuite struct { | 24 | type UtilsTestSuite struct { |
213 | 25 | 25 | ||
214 | === modified file 'policy/policy_test.go' | |||
215 | --- policy/policy_test.go 2015-04-17 06:42:44 +0000 | |||
216 | +++ policy/policy_test.go 2015-08-02 12:24:18 +0000 | |||
217 | @@ -24,11 +24,12 @@ | |||
218 | 24 | "path/filepath" | 24 | "path/filepath" |
219 | 25 | "testing" | 25 | "testing" |
220 | 26 | 26 | ||
221 | 27 | . "launchpad.net/gocheck" | ||
222 | 28 | "sort" | 27 | "sort" |
223 | 28 | |||
224 | 29 | . "gopkg.in/check.v1" | ||
225 | 29 | ) | 30 | ) |
226 | 30 | 31 | ||
228 | 31 | // Hook up gocheck into the "go test" runner. | 32 | // Hook up check.v1 into the "go test" runner. |
229 | 32 | func Test(t *testing.T) { TestingT(t) } | 33 | func Test(t *testing.T) { TestingT(t) } |
230 | 33 | 34 | ||
231 | 34 | type policySuite struct { | 35 | type policySuite struct { |
232 | 35 | 36 | ||
233 | === modified file 'priv/priv_test.go' | |||
234 | --- priv/priv_test.go 2015-03-26 09:12:58 +0000 | |||
235 | +++ priv/priv_test.go 2015-08-02 12:24:18 +0000 | |||
236 | @@ -23,7 +23,7 @@ | |||
237 | 23 | "path/filepath" | 23 | "path/filepath" |
238 | 24 | "testing" | 24 | "testing" |
239 | 25 | 25 | ||
241 | 26 | . "launchpad.net/gocheck" | 26 | . "gopkg.in/check.v1" |
242 | 27 | ) | 27 | ) |
243 | 28 | 28 | ||
244 | 29 | func Test(t *testing.T) { TestingT(t) } | 29 | func Test(t *testing.T) { TestingT(t) } |
245 | 30 | 30 | ||
246 | === modified file 'progress/progress_test.go' | |||
247 | --- progress/progress_test.go 2015-05-29 13:41:55 +0000 | |||
248 | +++ progress/progress_test.go 2015-08-02 12:24:18 +0000 | |||
249 | @@ -23,10 +23,10 @@ | |||
250 | 23 | "os" | 23 | "os" |
251 | 24 | "testing" | 24 | "testing" |
252 | 25 | 25 | ||
254 | 26 | . "launchpad.net/gocheck" | 26 | . "gopkg.in/check.v1" |
255 | 27 | ) | 27 | ) |
256 | 28 | 28 | ||
258 | 29 | // Hook up gocheck into the "go test" runner | 29 | // Hook up check.v1 into the "go test" runner |
259 | 30 | func Test(t *testing.T) { TestingT(t) } | 30 | func Test(t *testing.T) { TestingT(t) } |
260 | 31 | 31 | ||
261 | 32 | type ProgressTestSuite struct { | 32 | type ProgressTestSuite struct { |
262 | 33 | 33 | ||
263 | === modified file 'release/release_test.go' | |||
264 | --- release/release_test.go 2015-04-18 19:10:25 +0000 | |||
265 | +++ release/release_test.go 2015-08-02 12:24:18 +0000 | |||
266 | @@ -24,10 +24,10 @@ | |||
267 | 24 | "path/filepath" | 24 | "path/filepath" |
268 | 25 | "testing" | 25 | "testing" |
269 | 26 | 26 | ||
271 | 27 | . "launchpad.net/gocheck" | 27 | . "gopkg.in/check.v1" |
272 | 28 | ) | 28 | ) |
273 | 29 | 29 | ||
275 | 30 | // Hook up gocheck into the "go test" runner | 30 | // Hook up check.v1 into the "go test" runner |
276 | 31 | func Test(t *testing.T) { TestingT(t) } | 31 | func Test(t *testing.T) { TestingT(t) } |
277 | 32 | 32 | ||
278 | 33 | type ReleaseTestSuite struct { | 33 | type ReleaseTestSuite struct { |
279 | 34 | 34 | ||
280 | === modified file 'snappy/auth_test.go' | |||
281 | --- snappy/auth_test.go 2015-07-06 15:35:48 +0000 | |||
282 | +++ snappy/auth_test.go 2015-08-02 12:24:18 +0000 | |||
283 | @@ -28,14 +28,14 @@ | |||
284 | 28 | "launchpad.net/snappy/helpers" | 28 | "launchpad.net/snappy/helpers" |
285 | 29 | "launchpad.net/snappy/oauth" | 29 | "launchpad.net/snappy/oauth" |
286 | 30 | 30 | ||
288 | 31 | . "launchpad.net/gocheck" | 31 | . "gopkg.in/check.v1" |
289 | 32 | ) | 32 | ) |
290 | 33 | 33 | ||
291 | 34 | const mockStoreInvalidLoginCode = 401 | 34 | const mockStoreInvalidLoginCode = 401 |
292 | 35 | const mockStoreInvalidLogin = ` | 35 | const mockStoreInvalidLogin = ` |
293 | 36 | { | 36 | { |
296 | 37 | "message": "Provided email/password is not correct.", | 37 | "message": "Provided email/password is not correct.", |
297 | 38 | "code": "INVALID_CREDENTIALS", | 38 | "code": "INVALID_CREDENTIALS", |
298 | 39 | "extra": {} | 39 | "extra": {} |
299 | 40 | } | 40 | } |
300 | 41 | ` | 41 | ` |
301 | @@ -43,22 +43,22 @@ | |||
302 | 43 | const mockStoreNeeds2faHTTPCode = 401 | 43 | const mockStoreNeeds2faHTTPCode = 401 |
303 | 44 | const mockStoreNeeds2fa = ` | 44 | const mockStoreNeeds2fa = ` |
304 | 45 | { | 45 | { |
307 | 46 | "message": "2-factor authentication required.", | 46 | "message": "2-factor authentication required.", |
308 | 47 | "code": "TWOFACTOR_REQUIRED", | 47 | "code": "TWOFACTOR_REQUIRED", |
309 | 48 | "extra": {} | 48 | "extra": {} |
310 | 49 | } | 49 | } |
311 | 50 | ` | 50 | ` |
312 | 51 | 51 | ||
313 | 52 | const mockStoreReturnToken = ` | 52 | const mockStoreReturnToken = ` |
314 | 53 | { | 53 | { |
323 | 54 | "openid": "the-open-id-string-that-is-also-the-consumer-key-in-our-store", | 54 | "openid": "the-open-id-string-that-is-also-the-consumer-key-in-our-store", |
324 | 55 | "token_name": "some-token-name", | 55 | "token_name": "some-token-name", |
325 | 56 | "date_updated": "2015-02-27T15:00:55.062", | 56 | "date_updated": "2015-02-27T15:00:55.062", |
326 | 57 | "token_key": "the-token-key", | 57 | "token_key": "the-token-key", |
327 | 58 | "consumer_secret": "the-consumer-secret", | 58 | "consumer_secret": "the-consumer-secret", |
328 | 59 | "href": "/api/v2/tokens/oauth/something", | 59 | "href": "/api/v2/tokens/oauth/something", |
329 | 60 | "date_created": "2015-02-27T14:54:30.863", | 60 | "date_created": "2015-02-27T14:54:30.863", |
330 | 61 | "consumer_key": "the-consumer-key", | 61 | "consumer_key": "the-consumer-key", |
331 | 62 | "token_secret": "the-token-secret" | 62 | "token_secret": "the-token-secret" |
332 | 63 | } | 63 | } |
333 | 64 | ` | 64 | ` |
334 | 65 | 65 | ||
335 | === modified file 'snappy/build_test.go' | |||
336 | --- snappy/build_test.go 2015-05-07 08:28:03 +0000 | |||
337 | +++ snappy/build_test.go 2015-08-02 12:24:18 +0000 | |||
338 | @@ -24,7 +24,7 @@ | |||
339 | 24 | "path/filepath" | 24 | "path/filepath" |
340 | 25 | "strings" | 25 | "strings" |
341 | 26 | 26 | ||
343 | 27 | . "launchpad.net/gocheck" | 27 | . "gopkg.in/check.v1" |
344 | 28 | ) | 28 | ) |
345 | 29 | 29 | ||
346 | 30 | func makeFakeDuCommand(c *C) string { | 30 | func makeFakeDuCommand(c *C) string { |
347 | 31 | 31 | ||
348 | === modified file 'snappy/click_test.go' | |||
349 | --- snappy/click_test.go 2015-07-06 15:33:44 +0000 | |||
350 | +++ snappy/click_test.go 2015-08-02 12:24:18 +0000 | |||
351 | @@ -28,7 +28,7 @@ | |||
352 | 28 | "strings" | 28 | "strings" |
353 | 29 | 29 | ||
354 | 30 | "github.com/mvo5/goconfigparser" | 30 | "github.com/mvo5/goconfigparser" |
356 | 31 | . "launchpad.net/gocheck" | 31 | . "gopkg.in/check.v1" |
357 | 32 | 32 | ||
358 | 33 | "launchpad.net/snappy/clickdeb" | 33 | "launchpad.net/snappy/clickdeb" |
359 | 34 | "launchpad.net/snappy/helpers" | 34 | "launchpad.net/snappy/helpers" |
360 | @@ -1118,7 +1118,7 @@ | |||
361 | 1118 | bins := []string{"hello", "goodbye", "missya"} | 1118 | bins := []string{"hello", "goodbye", "missya"} |
362 | 1119 | for i := range verbs { | 1119 | for i := range verbs { |
363 | 1120 | expected := fmt.Sprintf("Exec%s=/usr/bin/ubuntu-core-launcher hello-app.%s %s_svc1_1.10 %s/bin/%s", verbs[i], testNamespace, helloAppComposedName, baseDirWithoutRootPrefix, bins[i]) | 1120 | expected := fmt.Sprintf("Exec%s=/usr/bin/ubuntu-core-launcher hello-app.%s %s_svc1_1.10 %s/bin/%s", verbs[i], testNamespace, helloAppComposedName, baseDirWithoutRootPrefix, bins[i]) |
365 | 1121 | c.Check(string(content), Matches, "(?ms).*^"+regexp.QuoteMeta(expected)) // gocheck adds ^ and $ around the regexp provided | 1121 | c.Check(string(content), Matches, "(?ms).*^"+regexp.QuoteMeta(expected)) // check.v1 adds ^ and $ around the regexp provided |
366 | 1122 | } | 1122 | } |
367 | 1123 | } | 1123 | } |
368 | 1124 | 1124 | ||
369 | 1125 | 1125 | ||
370 | === modified file 'snappy/common_test.go' | |||
371 | --- snappy/common_test.go 2015-04-30 16:56:15 +0000 | |||
372 | +++ snappy/common_test.go 2015-08-02 12:24:18 +0000 | |||
373 | @@ -26,9 +26,10 @@ | |||
374 | 26 | 26 | ||
375 | 27 | "launchpad.net/snappy/helpers" | 27 | "launchpad.net/snappy/helpers" |
376 | 28 | 28 | ||
377 | 29 | "strings" | ||
378 | 30 | |||
379 | 31 | . "gopkg.in/check.v1" | ||
380 | 29 | "gopkg.in/yaml.v2" | 32 | "gopkg.in/yaml.v2" |
381 | 30 | . "launchpad.net/gocheck" | ||
382 | 31 | "strings" | ||
383 | 32 | ) | 33 | ) |
384 | 33 | 34 | ||
385 | 34 | const ( | 35 | const ( |
386 | 35 | 36 | ||
387 | === modified file 'snappy/config_test.go' | |||
388 | --- snappy/config_test.go 2015-04-17 20:32:02 +0000 | |||
389 | +++ snappy/config_test.go 2015-08-02 12:24:18 +0000 | |||
390 | @@ -23,7 +23,7 @@ | |||
391 | 23 | "os" | 23 | "os" |
392 | 24 | "path/filepath" | 24 | "path/filepath" |
393 | 25 | 25 | ||
395 | 26 | . "launchpad.net/gocheck" | 26 | . "gopkg.in/check.v1" |
396 | 27 | ) | 27 | ) |
397 | 28 | 28 | ||
398 | 29 | const configPassthroughScript = `#!/bin/sh | 29 | const configPassthroughScript = `#!/bin/sh |
399 | 30 | 30 | ||
400 | === modified file 'snappy/datadir_test.go' | |||
401 | --- snappy/datadir_test.go 2015-04-20 13:01:02 +0000 | |||
402 | +++ snappy/datadir_test.go 2015-08-02 12:24:18 +0000 | |||
403 | @@ -22,7 +22,7 @@ | |||
404 | 22 | "path/filepath" | 22 | "path/filepath" |
405 | 23 | "strings" | 23 | "strings" |
406 | 24 | 24 | ||
408 | 25 | . "launchpad.net/gocheck" | 25 | . "gopkg.in/check.v1" |
409 | 26 | ) | 26 | ) |
410 | 27 | 27 | ||
411 | 28 | type DataDirSuite struct{} | 28 | type DataDirSuite struct{} |
412 | 29 | 29 | ||
413 | === modified file 'snappy/dbus_test.go' | |||
414 | --- snappy/dbus_test.go 2015-04-19 01:24:03 +0000 | |||
415 | +++ snappy/dbus_test.go 2015-08-02 12:24:18 +0000 | |||
416 | @@ -1,7 +1,7 @@ | |||
417 | 1 | package snappy | 1 | package snappy |
418 | 2 | 2 | ||
419 | 3 | import ( | 3 | import ( |
421 | 4 | . "launchpad.net/gocheck" | 4 | . "gopkg.in/check.v1" |
422 | 5 | ) | 5 | ) |
423 | 6 | 6 | ||
424 | 7 | // systemd's testsuite | 7 | // systemd's testsuite |
425 | 8 | 8 | ||
426 | === modified file 'snappy/firstboot_test.go' | |||
427 | --- snappy/firstboot_test.go 2015-04-14 16:46:57 +0000 | |||
428 | +++ snappy/firstboot_test.go 2015-08-02 12:24:18 +0000 | |||
429 | @@ -22,7 +22,7 @@ | |||
430 | 22 | "os" | 22 | "os" |
431 | 23 | "path/filepath" | 23 | "path/filepath" |
432 | 24 | 24 | ||
434 | 25 | . "launchpad.net/gocheck" | 25 | . "gopkg.in/check.v1" |
435 | 26 | ) | 26 | ) |
436 | 27 | 27 | ||
437 | 28 | type fakePart struct { | 28 | type fakePart struct { |
438 | 29 | 29 | ||
439 | === modified file 'snappy/hashes_test.go' | |||
440 | --- snappy/hashes_test.go 2015-03-31 14:12:52 +0000 | |||
441 | +++ snappy/hashes_test.go 2015-08-02 12:24:18 +0000 | |||
442 | @@ -24,7 +24,7 @@ | |||
443 | 24 | 24 | ||
444 | 25 | "gopkg.in/yaml.v2" | 25 | "gopkg.in/yaml.v2" |
445 | 26 | 26 | ||
447 | 27 | . "launchpad.net/gocheck" | 27 | . "gopkg.in/check.v1" |
448 | 28 | ) | 28 | ) |
449 | 29 | 29 | ||
450 | 30 | var fileHashYaml = `name: foo | 30 | var fileHashYaml = `name: foo |
451 | 31 | 31 | ||
452 | === modified file 'snappy/hwaccess_test.go' | |||
453 | --- snappy/hwaccess_test.go 2015-05-01 12:32:42 +0000 | |||
454 | +++ snappy/hwaccess_test.go 2015-08-02 12:24:18 +0000 | |||
455 | @@ -23,7 +23,7 @@ | |||
456 | 23 | 23 | ||
457 | 24 | "launchpad.net/snappy/helpers" | 24 | "launchpad.net/snappy/helpers" |
458 | 25 | 25 | ||
460 | 26 | . "launchpad.net/gocheck" | 26 | . "gopkg.in/check.v1" |
461 | 27 | ) | 27 | ) |
462 | 28 | 28 | ||
463 | 29 | func mockRegenerateAppArmorRules() *bool { | 29 | func mockRegenerateAppArmorRules() *bool { |
464 | 30 | 30 | ||
465 | === modified file 'snappy/install_test.go' | |||
466 | --- snappy/install_test.go 2015-04-17 20:54:23 +0000 | |||
467 | +++ snappy/install_test.go 2015-08-02 12:24:18 +0000 | |||
468 | @@ -26,7 +26,7 @@ | |||
469 | 26 | "os" | 26 | "os" |
470 | 27 | "path/filepath" | 27 | "path/filepath" |
471 | 28 | 28 | ||
473 | 29 | . "launchpad.net/gocheck" | 29 | . "gopkg.in/check.v1" |
474 | 30 | "launchpad.net/snappy/helpers" | 30 | "launchpad.net/snappy/helpers" |
475 | 31 | "launchpad.net/snappy/progress" | 31 | "launchpad.net/snappy/progress" |
476 | 32 | ) | 32 | ) |
477 | 33 | 33 | ||
478 | === modified file 'snappy/oem_test.go' | |||
479 | --- snappy/oem_test.go 2015-04-22 12:55:07 +0000 | |||
480 | +++ snappy/oem_test.go 2015-08-02 12:24:18 +0000 | |||
481 | @@ -26,7 +26,7 @@ | |||
482 | 26 | 26 | ||
483 | 27 | "launchpad.net/snappy/helpers" | 27 | "launchpad.net/snappy/helpers" |
484 | 28 | 28 | ||
486 | 29 | . "launchpad.net/gocheck" | 29 | . "gopkg.in/check.v1" |
487 | 30 | ) | 30 | ) |
488 | 31 | 31 | ||
489 | 32 | type OemSuite struct { | 32 | type OemSuite struct { |
490 | 33 | 33 | ||
491 | === modified file 'snappy/parts_test.go' | |||
492 | --- snappy/parts_test.go 2015-04-21 12:05:22 +0000 | |||
493 | +++ snappy/parts_test.go 2015-08-02 12:24:18 +0000 | |||
494 | @@ -22,7 +22,7 @@ | |||
495 | 22 | "os" | 22 | "os" |
496 | 23 | "path/filepath" | 23 | "path/filepath" |
497 | 24 | 24 | ||
499 | 25 | . "launchpad.net/gocheck" | 25 | . "gopkg.in/check.v1" |
500 | 26 | 26 | ||
501 | 27 | "launchpad.net/snappy/progress" | 27 | "launchpad.net/snappy/progress" |
502 | 28 | ) | 28 | ) |
503 | 29 | 29 | ||
504 | === modified file 'snappy/purge_test.go' | |||
505 | --- snappy/purge_test.go 2015-04-20 19:26:04 +0000 | |||
506 | +++ snappy/purge_test.go 2015-08-02 12:24:18 +0000 | |||
507 | @@ -23,7 +23,7 @@ | |||
508 | 23 | "os" | 23 | "os" |
509 | 24 | "path/filepath" | 24 | "path/filepath" |
510 | 25 | 25 | ||
512 | 26 | . "launchpad.net/gocheck" | 26 | . "gopkg.in/check.v1" |
513 | 27 | 27 | ||
514 | 28 | "launchpad.net/snappy/helpers" | 28 | "launchpad.net/snappy/helpers" |
515 | 29 | "launchpad.net/snappy/systemd" | 29 | "launchpad.net/snappy/systemd" |
516 | 30 | 30 | ||
517 | === modified file 'snappy/remove_test.go' | |||
518 | --- snappy/remove_test.go 2015-04-15 13:17:22 +0000 | |||
519 | +++ snappy/remove_test.go 2015-08-02 12:24:18 +0000 | |||
520 | @@ -18,7 +18,7 @@ | |||
521 | 18 | package snappy | 18 | package snappy |
522 | 19 | 19 | ||
523 | 20 | import ( | 20 | import ( |
525 | 21 | . "launchpad.net/gocheck" | 21 | . "gopkg.in/check.v1" |
526 | 22 | "launchpad.net/snappy/progress" | 22 | "launchpad.net/snappy/progress" |
527 | 23 | ) | 23 | ) |
528 | 24 | 24 | ||
529 | 25 | 25 | ||
530 | === modified file 'snappy/rollback_test.go' | |||
531 | --- snappy/rollback_test.go 2015-04-30 16:56:15 +0000 | |||
532 | +++ snappy/rollback_test.go 2015-08-02 12:24:18 +0000 | |||
533 | @@ -18,7 +18,7 @@ | |||
534 | 18 | package snappy | 18 | package snappy |
535 | 19 | 19 | ||
536 | 20 | import ( | 20 | import ( |
538 | 21 | . "launchpad.net/gocheck" | 21 | . "gopkg.in/check.v1" |
539 | 22 | ) | 22 | ) |
540 | 23 | 23 | ||
541 | 24 | func (s *SnapTestSuite) TestRollbackWithVersion(c *C) { | 24 | func (s *SnapTestSuite) TestRollbackWithVersion(c *C) { |
542 | 25 | 25 | ||
543 | === modified file 'snappy/security_test.go' | |||
544 | --- snappy/security_test.go 2015-07-06 19:56:46 +0000 | |||
545 | +++ snappy/security_test.go 2015-08-02 12:24:18 +0000 | |||
546 | @@ -5,7 +5,7 @@ | |||
547 | 5 | "os" | 5 | "os" |
548 | 6 | "path/filepath" | 6 | "path/filepath" |
549 | 7 | 7 | ||
551 | 8 | . "launchpad.net/gocheck" | 8 | . "gopkg.in/check.v1" |
552 | 9 | ) | 9 | ) |
553 | 10 | 10 | ||
554 | 11 | type SecurityTestSuite struct { | 11 | type SecurityTestSuite struct { |
555 | 12 | 12 | ||
556 | === modified file 'snappy/set_test.go' | |||
557 | --- snappy/set_test.go 2015-04-30 16:56:15 +0000 | |||
558 | +++ snappy/set_test.go 2015-08-02 12:24:18 +0000 | |||
559 | @@ -22,7 +22,7 @@ | |||
560 | 22 | "path/filepath" | 22 | "path/filepath" |
561 | 23 | "strings" | 23 | "strings" |
562 | 24 | 24 | ||
564 | 25 | . "launchpad.net/gocheck" | 25 | . "gopkg.in/check.v1" |
565 | 26 | 26 | ||
566 | 27 | "launchpad.net/snappy/progress" | 27 | "launchpad.net/snappy/progress" |
567 | 28 | ) | 28 | ) |
568 | 29 | 29 | ||
569 | === modified file 'snappy/snapp_test.go' | |||
570 | --- snappy/snapp_test.go 2015-07-07 02:35:22 +0000 | |||
571 | +++ snappy/snapp_test.go 2015-08-02 12:24:18 +0000 | |||
572 | @@ -34,7 +34,7 @@ | |||
573 | 34 | "launchpad.net/snappy/release" | 34 | "launchpad.net/snappy/release" |
574 | 35 | "launchpad.net/snappy/systemd" | 35 | "launchpad.net/snappy/systemd" |
575 | 36 | 36 | ||
577 | 37 | . "launchpad.net/gocheck" | 37 | . "gopkg.in/check.v1" |
578 | 38 | ) | 38 | ) |
579 | 39 | 39 | ||
580 | 40 | type SnapTestSuite struct { | 40 | type SnapTestSuite struct { |
581 | 41 | 41 | ||
582 | === modified file 'snappy/sort_test.go' | |||
583 | --- snappy/sort_test.go 2015-03-26 09:12:58 +0000 | |||
584 | +++ snappy/sort_test.go 2015-08-02 12:24:18 +0000 | |||
585 | @@ -20,7 +20,7 @@ | |||
586 | 20 | import ( | 20 | import ( |
587 | 21 | "sort" | 21 | "sort" |
588 | 22 | 22 | ||
590 | 23 | . "launchpad.net/gocheck" | 23 | . "gopkg.in/check.v1" |
591 | 24 | ) | 24 | ) |
592 | 25 | 25 | ||
593 | 26 | type SortTestSuite struct { | 26 | type SortTestSuite struct { |
594 | 27 | 27 | ||
595 | === modified file 'snappy/systemimage_native_test.go' | |||
596 | --- snappy/systemimage_native_test.go 2015-03-26 09:12:58 +0000 | |||
597 | +++ snappy/systemimage_native_test.go 2015-08-02 12:24:18 +0000 | |||
598 | @@ -25,7 +25,7 @@ | |||
599 | 25 | "path/filepath" | 25 | "path/filepath" |
600 | 26 | "time" | 26 | "time" |
601 | 27 | 27 | ||
603 | 28 | . "launchpad.net/gocheck" | 28 | . "gopkg.in/check.v1" |
604 | 29 | ) | 29 | ) |
605 | 30 | 30 | ||
606 | 31 | /* acquired via: | 31 | /* acquired via: |
607 | 32 | 32 | ||
608 | === modified file 'snappy/systemimage_test.go' | |||
609 | --- snappy/systemimage_test.go 2015-07-15 07:37:44 +0000 | |||
610 | +++ snappy/systemimage_test.go 2015-08-02 12:24:18 +0000 | |||
611 | @@ -28,10 +28,10 @@ | |||
612 | 28 | 28 | ||
613 | 29 | partition "launchpad.net/snappy/partition" | 29 | partition "launchpad.net/snappy/partition" |
614 | 30 | 30 | ||
616 | 31 | . "launchpad.net/gocheck" | 31 | . "gopkg.in/check.v1" |
617 | 32 | ) | 32 | ) |
618 | 33 | 33 | ||
620 | 34 | // Hook up gocheck into the "go test" runner | 34 | // Hook up check.v1 into the "go test" runner |
621 | 35 | func Test(t *testing.T) { TestingT(t) } | 35 | func Test(t *testing.T) { TestingT(t) } |
622 | 36 | 36 | ||
623 | 37 | type SITestSuite struct { | 37 | type SITestSuite struct { |
624 | 38 | 38 | ||
625 | === modified file 'snappy/timeout_test.go' | |||
626 | --- snappy/timeout_test.go 2015-04-13 22:20:58 +0000 | |||
627 | +++ snappy/timeout_test.go 2015-08-02 12:24:18 +0000 | |||
628 | @@ -21,7 +21,7 @@ | |||
629 | 21 | "encoding/json" | 21 | "encoding/json" |
630 | 22 | "time" | 22 | "time" |
631 | 23 | 23 | ||
633 | 24 | . "launchpad.net/gocheck" | 24 | . "gopkg.in/check.v1" |
634 | 25 | ) | 25 | ) |
635 | 26 | 26 | ||
636 | 27 | func (s *SnapTestSuite) TestTimeoutMarshal(c *C) { | 27 | func (s *SnapTestSuite) TestTimeoutMarshal(c *C) { |
637 | 28 | 28 | ||
638 | === modified file 'snappy/udev_test.go' | |||
639 | --- snappy/udev_test.go 2015-04-20 12:50:45 +0000 | |||
640 | +++ snappy/udev_test.go 2015-08-02 12:24:18 +0000 | |||
641 | @@ -18,7 +18,7 @@ | |||
642 | 18 | package snappy | 18 | package snappy |
643 | 19 | 19 | ||
644 | 20 | import ( | 20 | import ( |
646 | 21 | . "launchpad.net/gocheck" | 21 | . "gopkg.in/check.v1" |
647 | 22 | ) | 22 | ) |
648 | 23 | 23 | ||
649 | 24 | func (s *SnapTestSuite) TestGetUdevPartName(c *C) { | 24 | func (s *SnapTestSuite) TestGetUdevPartName(c *C) { |
650 | 25 | 25 | ||
651 | === modified file 'systemd/systemd_test.go' | |||
652 | --- systemd/systemd_test.go 2015-07-06 15:33:44 +0000 | |||
653 | +++ systemd/systemd_test.go 2015-08-02 12:24:18 +0000 | |||
654 | @@ -24,7 +24,7 @@ | |||
655 | 24 | "testing" | 24 | "testing" |
656 | 25 | "time" | 25 | "time" |
657 | 26 | 26 | ||
659 | 27 | . "launchpad.net/gocheck" | 27 | . "gopkg.in/check.v1" |
660 | 28 | 28 | ||
661 | 29 | "launchpad.net/snappy/helpers" | 29 | "launchpad.net/snappy/helpers" |
662 | 30 | ) | 30 | ) |
663 | @@ -37,7 +37,7 @@ | |||
664 | 37 | tr.msgs = append(tr.msgs, msg) | 37 | tr.msgs = append(tr.msgs, msg) |
665 | 38 | } | 38 | } |
666 | 39 | 39 | ||
668 | 40 | // Hook up gocheck into the "go test" runner | 40 | // Hook up check.v1 into the "go test" runner |
669 | 41 | func Test(t *testing.T) { TestingT(t) } | 41 | func Test(t *testing.T) { TestingT(t) } |
670 | 42 | 42 | ||
671 | 43 | // systemd's testsuite | 43 | // systemd's testsuite |
LGTM, thanks