Snappy

Merge lp:~elopio/snappy/add_tests_tests into lp:~snappy-dev/snappy/snappy-moved-to-github

  1. add_tests_tests
  2. Merge into snappy-moved-to-github
Proposed by Leo Arias
Status: Merged
Approved by: Leo Arias
Approved revision: 607
Merged at revision: 599
Proposed branch: lp:~elopio/snappy/add_tests_tests
Merge into: lp:~snappy-dev/snappy/snappy-moved-to-github
Prerequisite: lp:~elopio/snappy/one_tests_package
Diff against target: 515 lines (+153/-68)
20 files modified
_integration-tests/helpers/common/common.go (+11/-20)
_integration-tests/helpers/config/config.go (+26/-26)
_integration-tests/helpers/config/config_test.go (+93/-0)
_integration-tests/helpers/image/image.go (+1/-1)
_integration-tests/main.go (+3/-3)
_integration-tests/tests/apt_test.go (+1/-1)
_integration-tests/tests/build_test.go (+1/-1)
_integration-tests/tests/failover_rclocal_crash_test.go (+1/-1)
_integration-tests/tests/failover_systemd_loop_test.go (+1/-1)
_integration-tests/tests/failover_test.go (+1/-1)
_integration-tests/tests/failover_zero_size_file_test.go (+1/-1)
_integration-tests/tests/info_test.go (+2/-2)
_integration-tests/tests/installApp_test.go (+1/-1)
_integration-tests/tests/installFramework_test.go (+1/-1)
_integration-tests/tests/list_test.go (+1/-1)
_integration-tests/tests/rollback_test.go (+1/-1)
_integration-tests/tests/search_test.go (+1/-1)
_integration-tests/tests/update_test.go (+1/-1)
_integration-tests/tests/writablePaths_test.go (+1/-1)
run-checks (+4/-3)
To merge this branch: bzr merge lp:~elopio/snappy/add_tests_tests
Reviewer Review Type Date Requested Status
Federico Gimenez (community) Approve
Review via email: mp+265583@code.launchpad.net

Commit message

Refactored the helpers to be able to add tests for them.
Added tests for the config helpers.

Description of the change

I used as an example the config package. Now thinking about it again is the worst example, because we will get rid of it in favor of the test arguments. Oh well...

To post a comment you must log in.
Revision history for this message
Federico Gimenez (fgimenez) wrote :

Great! Very good idea the config encapsulation and the helpers folder =)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added directory '_integration-tests/helpers'
=== renamed directory '_integration-tests/common' => '_integration-tests/helpers/common'
=== modified file '_integration-tests/helpers/common/common.go'
--- _integration-tests/common/common.go 2015-07-22 15:12:24 +0000
+++ _integration-tests/helpers/common/common.go 2015-07-22 19:10:34 +0000
@@ -20,7 +20,6 @@
20package common20package common
2121
22import (22import (
23 "encoding/json"
24 "fmt"23 "fmt"
25 "io/ioutil"24 "io/ioutil"
26 "os"25 "os"
@@ -31,6 +30,8 @@
31 "strings"30 "strings"
3231
33 check "gopkg.in/check.v1"32 check "gopkg.in/check.v1"
33
34 "launchpad.net/snappy/_integration-tests/helpers/config"
34)35)
3536
36const (37const (
@@ -40,9 +41,9 @@
40 channelCfgFile = "/etc/system-image/channel.ini"41 channelCfgFile = "/etc/system-image/channel.ini"
41)42)
4243
43// Config is a map of strings that contains the configurations values passed44// Cfg is a struct that contains the configurations values passed from the
44// from the host to the testbed.45// host to the testbed.
45var Config map[string]string46var Cfg config.Config
4647
47// SnappySuite is a structure used as a base test suite for all the snappy48// SnappySuite is a structure used as a base test suite for all the snappy
48// integration tests.49// integration tests.
@@ -56,9 +57,11 @@
56 ExecCommand(c, "sudo", "systemctl", "stop", "snappy-autopilot.timer")57 ExecCommand(c, "sudo", "systemctl", "stop", "snappy-autopilot.timer")
57 ExecCommand(c, "sudo", "systemctl", "disable", "snappy-autopilot.timer")58 ExecCommand(c, "sudo", "systemctl", "disable", "snappy-autopilot.timer")
58 if !isInRebootProcess() {59 if !isInRebootProcess() {
59 Config = readConfig(c)60 Cfg, err := config.ReadConfig(
60 if Config["update"] == "true" || Config["rollback"] == "true" {61 "_integration-tests/data/output/testconfig.json")
61 switchSystemImageConf(c, Config["targetRelease"], Config["targetChannel"], "0")62 c.Assert(err, check.IsNil, check.Commentf("Error reading config: %v", err))
63 if Cfg.Update || Cfg.Rollback {
64 switchSystemImageConf(c, Cfg.TargetRelease, Cfg.TargetChannel, "0")
62 // Always use the installed snappy because we are updating from an old65 // Always use the installed snappy because we are updating from an old
63 // image, so we should not use the snappy from the branch.66 // image, so we should not use the snappy from the branch.
64 output := ExecCommand(c, "sudo", "/usr/bin/snappy", "update")67 output := ExecCommand(c, "sudo", "/usr/bin/snappy", "update")
@@ -68,7 +71,7 @@
68 }71 }
69 } else if CheckRebootMark("setupsuite-update") {72 } else if CheckRebootMark("setupsuite-update") {
70 RemoveRebootMark(c)73 RemoveRebootMark(c)
71 if Config["rollback"] == "true" {74 if Cfg.Rollback {
72 ExecCommand(c, "sudo", "snappy", "rollback", "ubuntu-core")75 ExecCommand(c, "sudo", "snappy", "rollback", "ubuntu-core")
73 RebootWithMark(c, "setupsuite-rollback")76 RebootWithMark(c, "setupsuite-rollback")
74 }77 }
@@ -137,18 +140,6 @@
137 s.cleanupHandlers = append(s.cleanupHandlers, f)140 s.cleanupHandlers = append(s.cleanupHandlers, f)
138}141}
139142
140func readConfig(c *check.C) map[string]string {
141 b, err := ioutil.ReadFile("_integration-tests/data/output/testconfig.json")
142 c.Assert(
143 err, check.IsNil, check.Commentf("Failed to read test config: %v", err))
144
145 var decoded map[string]string
146 err = json.Unmarshal(b, &decoded)
147 c.Assert(
148 err, check.IsNil, check.Commentf("Failed to decode test config: %v", err))
149 return decoded
150}
151
152func switchSystemImageConf(c *check.C, release, channel, version string) {143func switchSystemImageConf(c *check.C, release, channel, version string) {
153 targets := []string{"/", BaseOtherPath}144 targets := []string{"/", BaseOtherPath}
154 for _, target := range targets {145 for _, target := range targets {
155146
=== renamed directory '_integration-tests/config' => '_integration-tests/helpers/config'
=== modified file '_integration-tests/helpers/config/config.go'
--- _integration-tests/config/config.go 2015-07-22 15:12:24 +0000
+++ _integration-tests/helpers/config/config.go 2015-07-22 19:10:34 +0000
@@ -24,51 +24,51 @@
24 "fmt"24 "fmt"
25 "io/ioutil"25 "io/ioutil"
26 "log"26 "log"
27 "strconv"
28)27)
2928
30// Config contains the values to pass to the test bed from the host.29// Config contains the values to pass to the test bed from the host.
31type Config struct {30type Config struct {
32 fileName string31 FileName string
33 release string32 Release string
34 channel string33 Channel string
35 targetRelease string34 TargetRelease string
36 targetChannel string35 TargetChannel string
37 update bool36 Update bool
38 rollback bool37 Rollback bool
39}38}
4039
41// NewConfig is the Config constructor40// NewConfig is the Config constructor
42func NewConfig(fileName, release, channel, targetRelease, targetChannel string, update, rollback bool) *Config {41func NewConfig(fileName, release, channel, targetRelease, targetChannel string, update, rollback bool) *Config {
43 return &Config{42 return &Config{
44 fileName: fileName, release: release, channel: channel,43 FileName: fileName, Release: release, Channel: channel,
45 targetRelease: targetRelease, targetChannel: targetChannel,44 TargetRelease: targetRelease, TargetChannel: targetChannel,
46 update: update, rollback: rollback,45 Update: update, Rollback: rollback,
47 }46 }
48}47}
4948
50// Write writes the config to a file that will be copied to the test bed.49// Write writes the config to a file that will be copied to the test bed.
51func (cfg Config) Write() {50func (cfg Config) Write() {
52 fmt.Println("Writing test config...")51 fmt.Println("Writing test config...")
53 testConfig := map[string]string{52 fmt.Println(cfg)
54 "release": cfg.release,53 encoded, err := json.Marshal(cfg)
55 "channel": cfg.channel,
56 }
57 if cfg.targetRelease != "" {
58 testConfig["targetRelease"] = cfg.targetRelease
59 }
60 if cfg.targetChannel != "" {
61 testConfig["targetChannel"] = cfg.targetChannel
62 }
63 testConfig["update"] = strconv.FormatBool(cfg.update)
64 testConfig["rollback"] = strconv.FormatBool(cfg.rollback)
65 fmt.Println(testConfig)
66 encoded, err := json.Marshal(testConfig)
67 if err != nil {54 if err != nil {
68 log.Fatalf("Error encoding the test config: %v", err)55 log.Fatalf("Error encoding the test config: %v", err)
69 }56 }
70 err = ioutil.WriteFile(cfg.fileName, encoded, 0644)57 err = ioutil.WriteFile(cfg.FileName, encoded, 0644)
71 if err != nil {58 if err != nil {
72 log.Fatalf("Error writing the test config: %v", err)59 log.Fatalf("Error writing the test config: %v", err)
73 }60 }
74}61}
62
63// ReadConfig the config from a file
64func ReadConfig(fileName string) (*Config, error) {
65 b, err := ioutil.ReadFile(fileName)
66 if err != nil {
67 return nil, err
68 }
69 var decoded Config
70 if err = json.Unmarshal(b, &decoded); err != nil {
71 return nil, err
72 }
73 return &decoded, nil
74}
7575
=== added file '_integration-tests/helpers/config/config_test.go'
--- _integration-tests/helpers/config/config_test.go 1970-01-01 00:00:00 +0000
+++ _integration-tests/helpers/config/config_test.go 2015-07-22 19:10:34 +0000
@@ -0,0 +1,93 @@
1// -*- Mode: Go; indent-tabs-mode: t -*-
2
3/*
4 * Copyright (C) 2014-2015 Canonical Ltd
5 *
6 * This program is free software: you can redistribute it and/or modify
7 * it under the terms of the GNU General Public License version 3 as
8 * published by the Free Software Foundation.
9 *
10 * This program is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 * GNU General Public License for more details.
14 *
15 * You should have received a copy of the GNU General Public License
16 * along with this program. If not, see <http://www.gnu.org/licenses/>.
17 *
18 */
19
20package config
21
22import (
23 "fmt"
24 "io/ioutil"
25 "os"
26 "path/filepath"
27 "testing"
28
29 check "gopkg.in/check.v1"
30)
31
32// Hook up check.v1 into the "go test" runner
33func Test(t *testing.T) { check.TestingT(t) }
34
35type ConfigSuite struct{}
36
37var _ = check.Suite(&ConfigSuite{})
38
39func testConfigFileName(c *check.C) string {
40 tmpDir, err := ioutil.TempDir("", "")
41 c.Assert(err, check.IsNil, check.Commentf(
42 "Error creating a temporary directory: %v", err))
43 return filepath.Join(tmpDir, "test.config")
44}
45
46func testConfigStruct(fileName string) *Config {
47 return NewConfig(
48 fileName,
49 "testrelease", "testchannel", "testtargetrelease", "testtargetchannel",
50 true, true)
51}
52func testConfigContents(fileName string) string {
53 return `{` +
54 fmt.Sprintf(`"FileName":"%s",`, fileName) +
55 `"Release":"testrelease",` +
56 `"Channel":"testchannel",` +
57 `"TargetRelease":"testtargetrelease",` +
58 `"TargetChannel":"testtargetchannel",` +
59 `"Update":true,` +
60 `"Rollback":true` +
61 `}`
62}
63
64func (s *ConfigSuite) TestWriteConfig(c *check.C) {
65 // Do not print to stdout.
66 devnull, err := os.Open(os.DevNull)
67 c.Assert(err, check.IsNil)
68 oldStdout := os.Stdout
69 os.Stdout = devnull
70 defer func() {
71 os.Stdout = oldStdout
72 }()
73 configFileName := testConfigFileName(c)
74
75 cfg := testConfigStruct(configFileName)
76 cfg.Write()
77
78 writtenConfig, err := ioutil.ReadFile(configFileName)
79 c.Assert(err, check.IsNil, check.Commentf("Error reading config: %v", err))
80 c.Assert(string(writtenConfig), check.Equals, testConfigContents(configFileName))
81}
82
83func (s *ConfigSuite) TestReadConfig(c *check.C) {
84 configFileName := testConfigFileName(c)
85
86 configContents := testConfigContents(configFileName)
87 ioutil.WriteFile(configFileName, []byte(configContents), 0644)
88
89 cfg, err := ReadConfig(configFileName)
90
91 c.Assert(err, check.IsNil, check.Commentf("Error reading config: %v", err))
92 c.Assert(cfg, check.DeepEquals, testConfigStruct(configFileName))
93}
094
=== renamed directory '_integration-tests/image' => '_integration-tests/helpers/image'
=== modified file '_integration-tests/helpers/image/image.go'
--- _integration-tests/image/image.go 2015-07-22 15:12:24 +0000
+++ _integration-tests/helpers/image/image.go 2015-07-22 19:10:34 +0000
@@ -24,7 +24,7 @@
24 "path/filepath"24 "path/filepath"
25 "strings"25 "strings"
2626
27 utils "../utils"27 "launchpad.net/snappy/_integration-tests/helpers/utils"
28)28)
2929
30// Image type encapsulates image actions30// Image type encapsulates image actions
3131
=== renamed directory '_integration-tests/utils' => '_integration-tests/helpers/utils'
=== modified file '_integration-tests/main.go'
--- _integration-tests/main.go 2015-07-22 19:10:34 +0000
+++ _integration-tests/main.go 2015-07-22 19:10:34 +0000
@@ -28,9 +28,9 @@
28 "strconv"28 "strconv"
29 "text/template"29 "text/template"
3030
31 config "./config"31 "launchpad.net/snappy/_integration-tests/helpers/config"
32 image "./image"32 "launchpad.net/snappy/_integration-tests/helpers/image"
33 utils "./utils"33 "launchpad.net/snappy/_integration-tests/helpers/utils"
34)34)
3535
36const (36const (
3737
=== modified file '_integration-tests/tests/apt_test.go'
--- _integration-tests/tests/apt_test.go 2015-07-22 19:10:34 +0000
+++ _integration-tests/tests/apt_test.go 2015-07-22 19:10:34 +0000
@@ -20,7 +20,7 @@
20package tests20package tests
2121
22import (22import (
23 . "launchpad.net/snappy/_integration-tests/common"23 . "launchpad.net/snappy/_integration-tests/helpers/common"
2424
25 check "gopkg.in/check.v1"25 check "gopkg.in/check.v1"
26)26)
2727
=== modified file '_integration-tests/tests/build_test.go'
--- _integration-tests/tests/build_test.go 2015-07-22 19:10:34 +0000
+++ _integration-tests/tests/build_test.go 2015-07-22 19:10:34 +0000
@@ -24,7 +24,7 @@
24 "os"24 "os"
25 "os/exec"25 "os/exec"
2626
27 . "launchpad.net/snappy/_integration-tests/common"27 . "launchpad.net/snappy/_integration-tests/helpers/common"
2828
29 . "gopkg.in/check.v1"29 . "gopkg.in/check.v1"
30)30)
3131
=== modified file '_integration-tests/tests/failover_rclocal_crash_test.go'
--- _integration-tests/tests/failover_rclocal_crash_test.go 2015-07-22 19:10:34 +0000
+++ _integration-tests/tests/failover_rclocal_crash_test.go 2015-07-22 19:10:34 +0000
@@ -22,7 +22,7 @@
22import (22import (
23 "fmt"23 "fmt"
2424
25 . "launchpad.net/snappy/_integration-tests/common"25 . "launchpad.net/snappy/_integration-tests/helpers/common"
2626
27 check "gopkg.in/check.v1"27 check "gopkg.in/check.v1"
28)28)
2929
=== modified file '_integration-tests/tests/failover_systemd_loop_test.go'
--- _integration-tests/tests/failover_systemd_loop_test.go 2015-07-22 19:10:34 +0000
+++ _integration-tests/tests/failover_systemd_loop_test.go 2015-07-22 19:10:34 +0000
@@ -22,7 +22,7 @@
22import (22import (
23 "fmt"23 "fmt"
2424
25 . "launchpad.net/snappy/_integration-tests/common"25 . "launchpad.net/snappy/_integration-tests/helpers/common"
2626
27 check "gopkg.in/check.v1"27 check "gopkg.in/check.v1"
28)28)
2929
=== modified file '_integration-tests/tests/failover_test.go'
--- _integration-tests/tests/failover_test.go 2015-07-22 19:10:34 +0000
+++ _integration-tests/tests/failover_test.go 2015-07-22 19:10:34 +0000
@@ -22,7 +22,7 @@
22import (22import (
23 check "gopkg.in/check.v1"23 check "gopkg.in/check.v1"
2424
25 . "launchpad.net/snappy/_integration-tests/common"25 . "launchpad.net/snappy/_integration-tests/helpers/common"
26)26)
2727
28var _ = check.Suite(&failoverSuite{})28var _ = check.Suite(&failoverSuite{})
2929
=== modified file '_integration-tests/tests/failover_zero_size_file_test.go'
--- _integration-tests/tests/failover_zero_size_file_test.go 2015-07-22 19:10:34 +0000
+++ _integration-tests/tests/failover_zero_size_file_test.go 2015-07-22 19:10:34 +0000
@@ -25,7 +25,7 @@
25 "path/filepath"25 "path/filepath"
26 "strings"26 "strings"
2727
28 . "launchpad.net/snappy/_integration-tests/common"28 . "launchpad.net/snappy/_integration-tests/helpers/common"
2929
30 check "gopkg.in/check.v1"30 check "gopkg.in/check.v1"
31)31)
3232
=== modified file '_integration-tests/tests/info_test.go'
--- _integration-tests/tests/info_test.go 2015-07-22 19:10:34 +0000
+++ _integration-tests/tests/info_test.go 2015-07-22 19:10:34 +0000
@@ -22,7 +22,7 @@
22import (22import (
23 "fmt"23 "fmt"
2424
25 . "launchpad.net/snappy/_integration-tests/common"25 . "launchpad.net/snappy/_integration-tests/helpers/common"
2626
27 check "gopkg.in/check.v1"27 check "gopkg.in/check.v1"
28)28)
@@ -37,7 +37,7 @@
37 infoOutput := ExecCommand(c, "snappy", "info")37 infoOutput := ExecCommand(c, "snappy", "info")
3838
39 expected := "(?ms)" +39 expected := "(?ms)" +
40 fmt.Sprintf("^release: ubuntu-core/%s/%s\n", Config["release"], Config["channel"]) +40 fmt.Sprintf("^release: ubuntu-core/%s/%s\n", Cfg.Release, Cfg.Channel) +
41 ".*"41 ".*"
4242
43 c.Assert(infoOutput, check.Matches, expected)43 c.Assert(infoOutput, check.Matches, expected)
4444
=== modified file '_integration-tests/tests/installApp_test.go'
--- _integration-tests/tests/installApp_test.go 2015-07-22 19:10:34 +0000
+++ _integration-tests/tests/installApp_test.go 2015-07-22 19:10:34 +0000
@@ -24,7 +24,7 @@
24 "os/exec"24 "os/exec"
25 "time"25 "time"
2626
27 . "launchpad.net/snappy/_integration-tests/common"27 . "launchpad.net/snappy/_integration-tests/helpers/common"
2828
29 check "gopkg.in/check.v1"29 check "gopkg.in/check.v1"
30)30)
3131
=== modified file '_integration-tests/tests/installFramework_test.go'
--- _integration-tests/tests/installFramework_test.go 2015-07-22 19:10:34 +0000
+++ _integration-tests/tests/installFramework_test.go 2015-07-22 19:10:34 +0000
@@ -23,7 +23,7 @@
23 "fmt"23 "fmt"
24 "regexp"24 "regexp"
2525
26 . "launchpad.net/snappy/_integration-tests/common"26 . "launchpad.net/snappy/_integration-tests/helpers/common"
2727
28 check "gopkg.in/check.v1"28 check "gopkg.in/check.v1"
29)29)
3030
=== modified file '_integration-tests/tests/list_test.go'
--- _integration-tests/tests/list_test.go 2015-07-22 19:10:34 +0000
+++ _integration-tests/tests/list_test.go 2015-07-22 19:10:34 +0000
@@ -23,7 +23,7 @@
23 "fmt"23 "fmt"
24 "os"24 "os"
2525
26 . "launchpad.net/snappy/_integration-tests/common"26 . "launchpad.net/snappy/_integration-tests/helpers/common"
2727
28 "github.com/mvo5/goconfigparser"28 "github.com/mvo5/goconfigparser"
29 check "gopkg.in/check.v1"29 check "gopkg.in/check.v1"
3030
=== modified file '_integration-tests/tests/rollback_test.go'
--- _integration-tests/tests/rollback_test.go 2015-07-22 19:10:34 +0000
+++ _integration-tests/tests/rollback_test.go 2015-07-22 19:10:34 +0000
@@ -22,7 +22,7 @@
22import (22import (
23 "strconv"23 "strconv"
2424
25 . "launchpad.net/snappy/_integration-tests/common"25 . "launchpad.net/snappy/_integration-tests/helpers/common"
2626
27 check "gopkg.in/check.v1"27 check "gopkg.in/check.v1"
28)28)
2929
=== modified file '_integration-tests/tests/search_test.go'
--- _integration-tests/tests/search_test.go 2015-07-22 19:10:34 +0000
+++ _integration-tests/tests/search_test.go 2015-07-22 19:10:34 +0000
@@ -20,7 +20,7 @@
20package tests20package tests
2121
22import (22import (
23 . "launchpad.net/snappy/_integration-tests/common"23 . "launchpad.net/snappy/_integration-tests/helpers/common"
2424
25 . "gopkg.in/check.v1"25 . "gopkg.in/check.v1"
26)26)
2727
=== modified file '_integration-tests/tests/update_test.go'
--- _integration-tests/tests/update_test.go 2015-07-22 19:10:34 +0000
+++ _integration-tests/tests/update_test.go 2015-07-22 19:10:34 +0000
@@ -20,7 +20,7 @@
20package tests20package tests
2121
22import (22import (
23 . "launchpad.net/snappy/_integration-tests/common"23 . "launchpad.net/snappy/_integration-tests/helpers/common"
2424
25 check "gopkg.in/check.v1"25 check "gopkg.in/check.v1"
26)26)
2727
=== modified file '_integration-tests/tests/writablePaths_test.go'
--- _integration-tests/tests/writablePaths_test.go 2015-07-22 19:10:34 +0000
+++ _integration-tests/tests/writablePaths_test.go 2015-07-22 19:10:34 +0000
@@ -27,7 +27,7 @@
27 "path/filepath"27 "path/filepath"
28 "strings"28 "strings"
2929
30 . "launchpad.net/snappy/_integration-tests/common"30 . "launchpad.net/snappy/_integration-tests/helpers/common"
3131
32 check "gopkg.in/check.v1"32 check "gopkg.in/check.v1"
33)33)
3434
=== modified file 'run-checks'
--- run-checks 2015-07-22 19:10:34 +0000
+++ run-checks 2015-07-22 19:10:34 +0000
@@ -1,5 +1,5 @@
1#!/bin/sh1#!/bin/sh
221;3803;0c
3set -ev3set -ev
44
5if which goctest >/dev/null; then5if which goctest >/dev/null; then
@@ -46,10 +46,11 @@
46echo Running vet46echo Running vet
47go vet ./...47go vet ./...
48go vet ./_integration-tests/tests/...48go vet ./_integration-tests/tests/...
49go vet ./_integration-tests/helpers/...
4950
50# golint51# golint
51echo Running lint52echo Running lint
52lint=$(golint ./... && golint ./_integration-tests/tests/...)53lint=$(golint ./... && golint ./_integration-tests/helpers/... && golint ./_integration-tests/tests/...)
53if [ -n "$lint" ]; then54if [ -n "$lint" ]; then
54 echo "Lint complains:"55 echo "Lint complains:"
55 echo $lint56 echo $lint
@@ -72,7 +73,7 @@
7273
73# the rabbit hole74# the rabbit hole
74echo Running the tests for the integration helpers75echo Running the tests for the integration helpers
75$goctest -v -cover ./_integration-tests/common/...76$goctest -v -cover ./_integration-tests/helpers/...
7677
77# integration suite in kvm78# integration suite in kvm
78if which adt-run >/dev/null 2>&1; then79if which adt-run >/dev/null 2>&1; then

Subscribers

People subscribed via source and target branches