Merge lp:~elopio/snappy-tests-job/bug-create-version-flags into lp:snappy-tests-job

Proposed by Leo Arias
Status: Merged
Approved by: Federico Gimenez
Approved revision: 74
Merged at revision: 74
Proposed branch: lp:~elopio/snappy-tests-job/bug-create-version-flags
Merge into: lp:snappy-tests-job
Diff against target: 18 lines (+3/-3)
1 file modified
cmd/snappy-cloud-client/main.go (+3/-3)
To merge this branch: bzr merge lp:~elopio/snappy-tests-job/bug-create-version-flags
Reviewer Review Type Date Requested Status
Federico Gimenez (community) Approve
Review via email: mp+285431@code.launchpad.net

Commit message

Fixed the snappy-cloud-client create flags.

To post a comment you must log in.
Revision history for this message
Federico Gimenez (fgimenez) wrote :

LGTM, thx

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'cmd/snappy-cloud-client/main.go'
--- cmd/snappy-cloud-client/main.go 2016-02-02 07:22:15 +0000
+++ cmd/snappy-cloud-client/main.go 2016-02-09 05:15:23 +0000
@@ -47,11 +47,11 @@
47 "Release of the image, defaults to "+defaultRelease)47 "Release of the image, defaults to "+defaultRelease)
48 channel = fCreate.String("channel", defaultChannel,48 channel = fCreate.String("channel", defaultChannel,
49 "Channel of the image, defaults to "+defaultChannel)49 "Channel of the image, defaults to "+defaultChannel)
50 version = flag.String("version", defaultVersion,50 version = fCreate.String("version", defaultVersion,
51 "Version of the image, defaults to the latest. It could be a negative number relative to the latest version, or a string that identifies the version.")51 "Version of the image, defaults to the latest. It could be a negative number relative to the latest version, or a string that identifies the version.")
52 imageType = flag.String("image-type", defaultImageType,52 imageType = fCreate.String("image-type", defaultImageType,
53 "Type of image to be built, this string will be put in the image name.")53 "Type of image to be built, this string will be put in the image name.")
54 pattern = flag.String("name-pattern", cloud.DefaultImgNameTpl,54 pattern = fCreate.String("name-pattern", cloud.DefaultImgNameTpl,
55 fmt.Sprintf(55 fmt.Sprintf(
56 "Pattern used when searching for images. This pattern can include %%[1]s, %%[2]s, %%[3]s and %%[4], which will be replaced with type, release, channel and version, respectively. Defaults to %s, which is the format we use to upload images.", cloud.DefaultImgNameTpl))56 "Pattern used when searching for images. This pattern can include %%[1]s, %%[2]s, %%[3]s and %%[4], which will be replaced with type, release, channel and version, respectively. Defaults to %s, which is the format we use to upload images.", cloud.DefaultImgNameTpl))
57 )57 )

Subscribers

People subscribed via source and target branches

to all changes: