Merge lp:~elopio/snapcraft/ubuntu-logger-bug into lp:~snappy-dev/snapcraft/core

[Leo Arias]

Fixed the call to the log from the ubuntu plugin, with a test.

[Michael Terry (mterry)]

Thanks!

review: Approve

=== modified file 'snapcraft/plugins/ubuntu.py'
--- snapcraft/plugins/ubuntu.py	2015-07-23 14:23:29 +0000
+++ snapcraft/plugins/ubuntu.py	2015-08-05 14:41:06 +0000
@@ -89,7 +89,7 @@
         for p in packages:
             if p not in alldeps:
                 exit = True
-                logger.error('Package %s not recognized' % p, file=sys.stderr)
+                logger.error("Package '{}' not recognized".format(p))
         if exit:
             sys.exit(1)
 

=== added file 'snapcraft/tests/test_ubuntu_plugin.py'
--- snapcraft/tests/test_ubuntu_plugin.py	1970-01-01 00:00:00 +0000
+++ snapcraft/tests/test_ubuntu_plugin.py	2015-08-05 14:41:06 +0000
@@ -0,0 +1,39 @@
+# -*- Mode:Python; indent-tabs-mode:nil; tab-width:4 -*-
+#
+# Copyright (C) 2015 Canonical Ltd
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 3 as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+import logging
+
+import fixtures
+
+from snapcraft import tests
+from snapcraft.plugins import ubuntu
+
+
+class UbuntuPluginTestCase(tests.TestCase):
+
+    def test_get_all_dep_packages_with_unrecognized_package(self):
+        fake_logger = fixtures.FakeLogger(level=logging.ERROR)
+        self.useFixture(fake_logger)
+
+        test_options = type('obj', (object,), {'package': False})
+        plugin = ubuntu.UbuntuPlugin('test_plugin', test_options)
+
+        with self.assertRaises(SystemExit) as raised:
+            plugin.get_all_dep_packages(['test_package'])
+
+        self.assertEqual(raised.exception.code, 1, 'Wrong exit code returned.')
+        self.assertEqual(
+            "Package 'test_package' not recognized\n", fake_logger.output)