lp:~elopio/snapcraft/fix1474022-lower_case

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~snappy-dev/snapcraft/core at revision 76

Michael Terry (community): Approve on 2015-07-13

Diff: 591 lines (+93/-93)

12 files modified

snapcraft/__init__.py (+6/-6)
snapcraft/cmds.py (+10/-10)
snapcraft/common.py (+2/-2)
snapcraft/plugin.py (+32/-32)
snapcraft/plugins/autotools_project.py (+2/-2)
snapcraft/plugins/cmake_project.py (+1/-1)
snapcraft/plugins/go14.py (+1/-1)
snapcraft/plugins/make_project.py (+1/-1)
snapcraft/plugins/ubuntu.py (+11/-11)
snapcraft/yaml.py (+15/-15)
tests/unit/test_cmds.py (+4/-4)
tests/unit/test_plugin.py (+8/-8)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1474022: method names are camelCAse

Undecided

Fix Released

Link a bug report

Related blueprints

81. By Leo Arias on 2015-07-13

Refactored the internal wrap_bins.

80. By Leo Arias on 2015-07-13

Linked to branch.

79. By Leo Arias on 2015-07-13

Finished lowercasing the rest of the methods.

78. By Leo Arias on 2015-07-13

s/snapFiles/snap_files

77. By Leo Arias on 2015-07-13

s/assembleEnv/assemble_env

76. By Leo Arias on 2015-07-13

s/checkForCollisions/check_for_collisions

75. By Michael Terry on 2015-07-10

Add support for local plugins in parts/plugins. by mterry approved by rsalveti

74. By Michael Terry on 2015-07-10

Add simple CMake support. by mterry approved by mvo

73. By Michael Terry on 2015-07-10

Add collision detection before staging, fix ordering of parts to be more reliable, and only export the environment of dependent parts when building each part. by mterry approved by rsalveti

72. By Michael Terry on 2015-07-10

Clean up part lifecycle logic a bit.

- Drop stage() and snap() calls from plugins. The core code now handles those. Plugins do get a new snapFiles() call that allows them to specify whitelist and blacklist globs. (To be expanded in the future by letting the user blacklist more files from yaml.)

- Add new parts/XXX/install directory. This is a sort of staging area for the staging area. It's useful in three ways: (1) We can detect two parts trying to install the same file into staging (though this isn't implemented yet); (2) We can restrict the whitelist globs from a part to only match the filenames that are in install/ (since otherwise it could match files from other parts in the combined staging area); (3) And we can build other parts against only the parts that they specify (using after/requires) rather than any part that happened to get installed into staging. These changes leave staging as just a play area for the user (to either edit or build their own code against).

- Unify existing plugin code a bit to use the same directories. All source code in src/, all binary code in build/ (even downloaded binary code), and all installed code in install/.

And I did some minor unrelated cleanup is also in this branch for convenience:

- When running locally, prepend (rather than append) our local snapcraft python module, so that any installed version doesn't get picked up instead.

- Allow skipping the plainbox tests via environment variable in runtests.sh by mterry approved by rsalveti,mvo