Code review comment for lp:~elopio/selenium-simple-test/download

Revision history for this message
Vincent Ladeuil (vila) wrote :

> This branch lacks the self test.

Or several.

Just reading quickly:

68 + if 'Content-Dispoisition' in info

'Content-Disposition' would have been caught by tests ;)

But more generally, sst is about delegating that kind of stuff to the browser (there are *many* weird cases you don't want to even try to support that are already properly handled there).

You can even write tests using 'file:///' urls

review: Needs Fixing

« Back to merge proposal