Canonical SSO provider

Code review comment for lp:~elopio/canonical-identity-provider/refactory_with_u1testutils-1

  1. refactory_with_u1testutils-1
  2. Merge into trunk
Revision history for this message
Ricardo Kirkner (ricardokirkner) wrote :

l. 35,37: no need to have the extra whitespace
l. 53: we could be using the new data-qa-id attrs for looking up elements (for better disambiguation)
l. 365,378: why did you remove the extended=true param?

review: Needs Fixing

« Back to merge proposal