> (I
> don't mind large MRs if a bunch of the lines are tests).
Should read:
(I don't mind if the MR is a little larger, it should be as small as
possible but currently it looks like it's a little too small if it
doesn't include all the details for the tests too.)
> Minor nit-pick: between diff lines 253 and 269 there is helper methods
> mixed in between test methods.
Should read:
Diff lines 253 and 269 Helper methods:
The helper methods should be public (shouldn't start with '_')
They are also mixed in between test methods, they should be at the
top of the class with the test methods following.
Oops, hit enter too soon, corrections below.
> (I
> don't mind large MRs if a bunch of the lines are tests).
Should read:
(I don't mind if the MR is a little larger, it should be as small as
possible but currently it looks like it's a little too small if it
doesn't include all the details for the tests too.)
> Minor nit-pick: between diff lines 253 and 269 there is helper methods
> mixed in between test methods.
Should read:
Diff lines 253 and 269 Helper methods:
The helper methods should be public (shouldn't start with '_')
They are also mixed in between test methods, they should be at the
top of the class with the test methods following.