Code review comment for lp:~elmo/ubuntu/oneiric/libstomp-ruby/bug-707317

Revision history for this message
James Troup (elmo) wrote :

Stefano Rivera <email address hidden> writes:

> * The version number really should be 1.1.9-0ubuntu1.

Even if I NMU it into Debian? ;-)

> * We shouldn't change source format just because we don't have any
> packages.

I assume you mean patches? If so, sorry, but why not? There are no
upstream changes anymore so making it source format 1 makes it easier to
backport to older distributions and AFAICS doesn't have any negative
side effects. What am I missing?

> * E: libstomp-ruby: ruby-script-but-no-ruby-dep usr/bin/catstomp
> E: libstomp-ruby: ruby-script-but-no-ruby-dep usr/bin/stompcat

Well, it has an indirect dependency via libstomp-ruby1.8 |
libstomp-ruby1.9.1. I guess I can make it an explicit dependency, if
you want.

--
James

« Back to merge proposal