Merge lp:~elfy/ubuntu-manual-tests/1374599 into lp:ubuntu-manual-tests

Proposed by Elfy on 2014-09-27
Status: Merged
Approved by: Walter Lapchynski on 2014-09-29
Approved revision: 291
Merged at revision: 291
Proposed branch: lp:~elfy/ubuntu-manual-tests/1374599
Merge into: lp:ubuntu-manual-tests
Diff against target: 26 lines (+4/-4)
1 file modified
testcases/packages/1510_Lxtask (+4/-4)
To merge this branch: bzr merge lp:~elfy/ubuntu-manual-tests/1374599
Reviewer Review Type Date Requested Status
Walter Lapchynski 2014-09-27 Approve on 2014-09-29
Review via email: mp+236222@code.launchpad.net

Description of the change

copy paste of bug changes

To post a comment you must log in.
Nicholas Skaggs (nskaggs) wrote :

Commented.

Elfy (elfy) wrote :

No idea why the original test does so - this just fixes a bug.

Nicholas Skaggs (nskaggs) wrote :

I would propose would could also fix the bug by simply removing it. That would be my preference, but I will not block.

Walter Lapchynski (wxl) wrote :

To Nicholas' point, I realize it seems like we're testing memory, but what we're actually testing is whether or not including caches shows the appropriate change. Then it seeks to test the reported values against what the system is reporting. So it's basically asking the question of whether or not lxtask's ability to report memory is accurate.

The problem was someone had their logic backwards when they wrote this originally. That and some unnecessary whitespace. ;)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'testcases/packages/1510_Lxtask'
2--- testcases/packages/1510_Lxtask 2013-08-03 10:34:11 +0000
3+++ testcases/packages/1510_Lxtask 2014-09-27 08:18:23 +0000
4@@ -7,12 +7,12 @@
5 <dd>Root tasks should now appear.</dd>
6 <dt>Click <em>View</em> and select <em>Show other tasks</em>.</dt>
7 <dd>Other tasks should now appear (e.g. whoopsie).</dd>
8- <dt>Click <em>View</em> and select <em>Show memory used by cache as free</em>.</dt>
9- <dd>Reported memory usage should decrease.</dd>
10+ <dt>Click <em>View</em> and unselect <em>Show memory used by cache as free</em>.</dt>
11+ <dd>Reported memory usage should increase.</dd>
12 <dt>To check the readings against system, launch <em>LxTerminal</em> (Menu --> Accessories --> LxTerminal) and issue the command <em>top</em>. Please note that <em>top</em> reports in Kib, so there is a factor 1.024 difference between kB and Kib. </dt>
13 <dd>A listing of running processes will appear in the terminal window. <strong> If this does not happen, see the test for LxTerminal to file a bug against it </strong>.</dd>
14 <dt>Click on the title bar <em>Command</em>.</dt>
15- <dd>The sort order should be changed in alpha-numeric sort order on each click.</dd>
16+ <dd>The sort order should be changed in alpha-numeric sort order on each click.</dd>
17 <dt> Repeat with <em>user</em>, <em>RSS</em>, <em>VMSize</em>, <em>PID</em>, <em>State</em>, <em>Prio</em> and <em>PPID</em>.</dt>
18 <dd>The sort order is changed each time.</dd>
19 <dt> Launch <em>LxTerminal</em> (Menu --> Accessories --> LxTerminal). </dt>
20@@ -29,4 +29,4 @@
21 <strong>
22 If all actions produce the expected results listed, please <a href="results#add_result">submit</a> a 'passed' result.
23 If an action fails, or produces an unexpected result, please <a href="results#add_result">submit</a> a 'failed' result and <a href="../../buginstructions">file a bug</a>.
24- Please be sure to include the bug number when you <a href="results#add_result">submit</a> your result</strong>.
25+ Please be sure to include the bug number when you <a href="results#add_result">submit</a> your result</strong>.
26\ No newline at end of file

Subscribers

People subscribed via source and target branches

to all changes: