Code review comment for lp:~elementary-pantheon/switchboard-plug-security-privacy/firewall-status
Revision history for this message
| David Hewitt (davidmhewitt) wrote | # |
review:
Approve
(code, function)
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
It's a shame that you have to be root to determine whether the firewall is running or not. I think moving to firewalld instead of UFW will fix that. Would be nice to have the status indicator always visible instead of just after you'd put an admin password in.
All looks good though.