Merge lp:~elementary-pantheon/switchboard-plug-pantheon-shell/even-top-margin into lp:~elementary-apps/switchboard-plug-pantheon-shell/trunk

Proposed by Danielle Foré
Status: Merged
Approved by: Corentin Noël
Approved revision: 555
Merged at revision: 556
Proposed branch: lp:~elementary-pantheon/switchboard-plug-pantheon-shell/even-top-margin
Merge into: lp:~elementary-apps/switchboard-plug-pantheon-shell/trunk
Diff against target: 81 lines (+8/-12)
4 files modified
src/Views/Dock.vala (+0/-2)
src/Views/HotCorners.vala (+0/-2)
src/Views/Wallpaper.vala (+7/-7)
src/desktop-plug.vala (+1/-1)
To merge this branch: bzr merge lp:~elementary-pantheon/switchboard-plug-pantheon-shell/even-top-margin
Reviewer Review Type Date Requested Status
elementary Apps team Pending
Review via email: mp+317278@code.launchpad.net

Commit message

* Remove top margins from individual panes
* Double space around the view switcher
* Place a separator above the wallpaper flowbox to give it upper bounds
* Re-color flowbox with the view class
* Make wallpaper view a grid subclass

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Views/Dock.vala'
--- src/Views/Dock.vala 2017-02-11 23:12:13 +0000
+++ src/Views/Dock.vala 2017-02-15 02:31:39 +0000
@@ -29,8 +29,6 @@
29 column_spacing = 12;29 column_spacing = 12;
30 halign = Gtk.Align.CENTER;30 halign = Gtk.Align.CENTER;
31 row_spacing = 6;31 row_spacing = 6;
32 margin = 24;
33 margin_top = 64;
3432
35 var icon_size = new Granite.Widgets.ModeButton ();33 var icon_size = new Granite.Widgets.ModeButton ();
36 icon_size.append_text (_("Small"));34 icon_size.append_text (_("Small"));
3735
=== modified file 'src/Views/HotCorners.vala'
--- src/Views/HotCorners.vala 2017-02-08 19:25:20 +0000
+++ src/Views/HotCorners.vala 2017-02-15 02:31:39 +0000
@@ -23,9 +23,7 @@
23 construct {23 construct {
24 column_spacing = 12;24 column_spacing = 12;
25 row_spacing = 24;25 row_spacing = 24;
26 margin = 32;
27 halign = Gtk.Align.CENTER;26 halign = Gtk.Align.CENTER;
28 valign = Gtk.Align.CENTER;
2927
30 var expl = new Gtk.Label (_("When the cursor enters the corner of the display:"));28 var expl = new Gtk.Label (_("When the cursor enters the corner of the display:"));
31 expl.get_style_context ().add_class ("h4");29 expl.get_style_context ().add_class ("h4");
3230
=== modified file 'src/Views/Wallpaper.vala'
--- src/Views/Wallpaper.vala 2017-02-14 19:30:26 +0000
+++ src/Views/Wallpaper.vala 2017-02-15 02:31:39 +0000
@@ -77,7 +77,7 @@
77 public abstract void set_background_file (string filename) throws IOError;77 public abstract void set_background_file (string filename) throws IOError;
78}78}
7979
80public class Wallpaper : Gtk.EventBox {80public class Wallpaper : Gtk.Grid {
81 // name of the default-wallpaper-link that we can prevent loading it again81 // name of the default-wallpaper-link that we can prevent loading it again
82 // (assumes that the defaultwallpaper is also in the system wallpaper directory)82 // (assumes that the defaultwallpaper is also in the system wallpaper directory)
83 static string DEFAULT_LINK = "file://%s/elementaryos-default".printf (SYSTEM_BACKGROUNDS_PATH);83 static string DEFAULT_LINK = "file://%s/elementaryos-default".printf (SYSTEM_BACKGROUNDS_PATH);
@@ -121,10 +121,12 @@
121 warning (e.message);121 warning (e.message);
122 }122 }
123123
124 var separator = new Gtk.Separator (Gtk.Orientation.HORIZONTAL);
125
124 wallpaper_view = new Gtk.FlowBox ();126 wallpaper_view = new Gtk.FlowBox ();
125 wallpaper_view.activate_on_single_click = true;127 wallpaper_view.activate_on_single_click = true;
126 wallpaper_view.column_spacing = wallpaper_view.row_spacing = 6;128 wallpaper_view.column_spacing = wallpaper_view.row_spacing = 6;
127 wallpaper_view.margin = 12;129 wallpaper_view.get_style_context ().add_class (Gtk.STYLE_CLASS_VIEW);
128 wallpaper_view.homogeneous = true;130 wallpaper_view.homogeneous = true;
129 wallpaper_view.selection_mode = Gtk.SelectionMode.SINGLE;131 wallpaper_view.selection_mode = Gtk.SelectionMode.SINGLE;
130 wallpaper_view.child_activated.connect (update_checked_wallpaper);132 wallpaper_view.child_activated.connect (update_checked_wallpaper);
@@ -179,11 +181,9 @@
179 actionbar.pack_end (color_button);181 actionbar.pack_end (color_button);
180 actionbar.pack_end (combo);182 actionbar.pack_end (combo);
181183
182 var grid = new Gtk.Grid ();184 attach (separator, 0, 0, 1, 1);
183 grid.margin_top = 24;185 attach (scrolled, 0, 1, 1, 1);
184 grid.attach (scrolled, 0, 0, 1, 1);186 attach (actionbar, 0, 2, 1, 1);
185 grid.attach (actionbar, 0, 1, 1, 1);
186 add (grid);
187 }187 }
188188
189 private void load_settings () {189 private void load_settings () {
190190
=== modified file 'src/desktop-plug.vala'
--- src/desktop-plug.vala 2016-12-21 18:48:26 +0000
+++ src/desktop-plug.vala 2017-02-15 02:31:39 +0000
@@ -53,7 +53,7 @@
53 var stack_switcher = new Gtk.StackSwitcher ();53 var stack_switcher = new Gtk.StackSwitcher ();
54 stack_switcher.stack = stack;54 stack_switcher.stack = stack;
55 stack_switcher.halign = Gtk.Align.CENTER;55 stack_switcher.halign = Gtk.Align.CENTER;
56 stack_switcher.margin_top = 12;56 stack_switcher.margin = 24;
5757
58 main_grid.attach (stack_switcher, 0, 0, 1, 1);58 main_grid.attach (stack_switcher, 0, 0, 1, 1);
59 main_grid.attach (stack, 0, 1, 1, 1);59 main_grid.attach (stack, 0, 1, 1, 1);

Subscribers

People subscribed via source and target branches