Code review comment for lp:~elementary-pantheon/switchboard-plug-networking/hotspot
Revision history for this message
| xapantu (xapantu) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
Ah yes I forgot to re-add the icons back after the refactor.
There is definitively a problem with the ethernet states…
On 20/12/2015 20:22, Daniel Fore wrote:
> Review: Needs Fixing
>
> Hm something has gone awry:
> * My Wireless connection shows an ethernet icon in the sidebar
> * When I disable my USB ethernet device, in the sidebar is shows "Cable unplugged" instead of "Disabled"
>
> * I think there should be some kind of explanation on the hotspot page. At the moment it's completely blank. We should explain what hotspot is and that you won't be able to connect to other wireless networks while it is enabled (basically the information from the connection dialog).
>
> * If I cancel creating the hotspot, the switch is still in the "on" position.
>