Merge lp:~elementary-pantheon/switchboard-plug-keyboard/organize-source into lp:~elementary-pantheon/switchboard-plug-keyboard/trunk

Proposed by Danielle Foré
Status: Merged
Approved by: Corentin Noël
Approved revision: 505
Merged at revision: 505
Proposed branch: lp:~elementary-pantheon/switchboard-plug-keyboard/organize-source
Merge into: lp:~elementary-pantheon/switchboard-plug-keyboard/trunk
Diff against target: 92 lines (+28/-24)
1 file modified
src/CMakeLists.txt (+28/-24)
To merge this branch: bzr merge lp:~elementary-pantheon/switchboard-plug-keyboard/organize-source
Reviewer Review Type Date Requested Status
elementary Pantheon team Pending
Review via email: mp+317040@code.launchpad.net

Commit message

* Add Dialogs, Views, and Widgets folders
* Move relevant files to these new directories
* Rename page.vala to AbstractPage.vala
* Rename add_layout.vala to AddLayoutPopover.vala
* CamelCase file names
* Update CMake

Description of the change

Trying to re-organize these files in the way you would expect for elementary code. Mainly this adds folders for Views, Dialogs, Widgets and moves relevant source files into these categories.

Also renamed a couple of files to make it more clear what they are

To post a comment you must log in.
505. By Danielle Foré

re-organize source files

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== renamed directory 'src/Pages/Behaviour' => 'src/Behavior'
=== renamed file 'src/Pages/Behaviour/settings.vala' => 'src/Behavior/Settings.vala'
=== modified file 'src/CMakeLists.txt'
--- src/CMakeLists.txt 2016-06-28 00:00:35 +0000
+++ src/CMakeLists.txt 2017-02-12 02:46:30 +0000
@@ -13,30 +13,34 @@
13include (ValaPrecompile)13include (ValaPrecompile)
14# Add all your vala files and required packages to the List below to include them in the build14# Add all your vala files and required packages to the List below to include them in the build
15vala_precompile (VALA_C ${CMAKE_PROJECT_NAME}15vala_precompile (VALA_C ${CMAKE_PROJECT_NAME}
16 keyboard.vala16 Keyboard.vala
17 page.vala17
1818 Behavior/Settings.vala
19 Pages/behaviour.vala19
20 Pages/Behaviour/settings.vala20 Dialogs/ConflictDialog.vala
2121
22 Pages/layout.vala 22 Layout/Handler.vala
23 Pages/Layout/display.vala23 Layout/Settings.vala
24 Pages/Layout/add_layout.vala24 Layout/XkbModifier.vala
25 Pages/Layout/handler.vala25
26 Pages/Layout/settings.vala26 Shortcuts/CustomShortcutSettings.vala
27 Pages/Layout/xkb_modifier.vala27 Shortcuts/List.vala
28 28 Shortcuts/Settings.vala
29 Pages/shortcuts.vala 29 Shortcuts/Shortcut.vala
30 Pages/Shortcuts/settings.vala30
31 Pages/Shortcuts/tree.vala31 Views/AbstractPage.vala
32 Pages/Shortcuts/display.vala32 Views/Behavior.vala
33 Pages/Shortcuts/shortcut.vala33 Views/Layout.vala
34 Pages/Shortcuts/list.vala34 Views/Shortcuts.vala
35 Pages/Shortcuts/section_switcher.vala35
36 Pages/Shortcuts/custom_tree.vala36 Widgets/Layout/AddLayoutPopover.vala
37 Pages/Shortcuts/custom_shortcut_settings.vala37 Widgets/Layout/Display.vala
38 Pages/Shortcuts/conflict_dialog.vala38
39 Pages/Shortcuts/display_tree.vala39 Widgets/Shortcuts/CustomTree.vala
40 Widgets/Shortcuts/Display.vala
41 Widgets/Shortcuts/DisplayTree.vala
42 Widgets/Shortcuts/SectionSwitcher.vala
43 Widgets/Shortcuts/Tree.vala
4044
41 ${CMAKE_CURRENT_BINARY_DIR}/config.vala45 ${CMAKE_CURRENT_BINARY_DIR}/config.vala
42PACKAGES46PACKAGES
4347
=== added directory 'src/Dialogs'
=== renamed file 'src/Pages/Shortcuts/conflict_dialog.vala' => 'src/Dialogs/ConflictDialog.vala'
=== renamed file 'src/keyboard.vala' => 'src/Keyboard.vala'
=== renamed directory 'src/Pages/Layout' => 'src/Layout'
=== renamed file 'src/Pages/Layout/handler.vala' => 'src/Layout/Handler.vala'
=== renamed file 'src/Pages/Layout/settings.vala' => 'src/Layout/Settings.vala'
=== renamed file 'src/Pages/Layout/xkb_modifier.vala' => 'src/Layout/XkbModifier.vala'
=== renamed directory 'src/Pages/Shortcuts' => 'src/Shortcuts'
=== renamed file 'src/Pages/Shortcuts/custom_shortcut_settings.vala' => 'src/Shortcuts/CustomShortcutSettings.vala'
=== renamed file 'src/Pages/Shortcuts/list.vala' => 'src/Shortcuts/List.vala'
=== renamed file 'src/Pages/Shortcuts/settings.vala' => 'src/Shortcuts/Settings.vala'
=== renamed file 'src/Pages/Shortcuts/shortcut.vala' => 'src/Shortcuts/Shortcut.vala'
=== renamed directory 'src/Pages' => 'src/Views'
=== renamed file 'src/page.vala' => 'src/Views/AbstractPage.vala'
=== renamed file 'src/Pages/behaviour.vala' => 'src/Views/Behavior.vala'
=== renamed file 'src/Pages/layout.vala' => 'src/Views/Layout.vala'
=== renamed file 'src/Pages/shortcuts.vala' => 'src/Views/Shortcuts.vala'
=== added directory 'src/Widgets'
=== added directory 'src/Widgets/Layout'
=== renamed file 'src/Pages/Layout/add_layout.vala' => 'src/Widgets/Layout/AddLayoutPopover.vala'
=== renamed file 'src/Pages/Layout/display.vala' => 'src/Widgets/Layout/Display.vala'
=== added directory 'src/Widgets/Shortcuts'
=== renamed file 'src/Pages/Shortcuts/custom_tree.vala' => 'src/Widgets/Shortcuts/CustomTree.vala'
=== renamed file 'src/Pages/Shortcuts/display.vala' => 'src/Widgets/Shortcuts/Display.vala'
=== renamed file 'src/Pages/Shortcuts/display_tree.vala' => 'src/Widgets/Shortcuts/DisplayTree.vala'
=== renamed file 'src/Pages/Shortcuts/section_switcher.vala' => 'src/Widgets/Shortcuts/SectionSwitcher.vala'
=== renamed file 'src/Pages/Shortcuts/tree.vala' => 'src/Widgets/Shortcuts/Tree.vala'

Subscribers

People subscribed via source and target branches