Code review comment for lp:~elementary-pantheon/granite/source-list

Revision history for this message
Victor Martinez (victored) wrote :

Some outstanding issues I've found:

1) Tree.start_editing_item() should check the "editing" property before starting another edit. Currently, if you hit the F2 key twice, the second key release will cancel the editing you started.

2) Comment in lines 1501-1505 is a falacy. Remove it.

3) The documentation of Sidebar.VisibleFunc feels a bit incomplete. It should point out that no item property should be modified from that function, or everything will freeze.

4) In the documentation of Sidebar.set_visible_func, "re-filter" should be "refilter", or valadoc will fail.

review: Needs Fixing

« Back to merge proposal